Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.gpxpy: init at 1.3.5 #76627

Merged
merged 1 commit into from Jan 12, 2020
Merged

python3Packages.gpxpy: init at 1.3.5 #76627

merged 1 commit into from Jan 12, 2020

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Dec 29, 2019

Motivation for this change

gpxpy - GPX file parser.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
$ nix path-info -Sh ./result
/nix/store/83z3y74jbf9n711ndvcp37fravn9h01m-gpxpy-1.3.5	 103.8M

jonringer
jonringer reviewed Jan 11, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change commit message to:

python3Packages.gpxpy: init at 1.3.5

otherwise LGTM

@sikmir sikmir force-pushed the gpxpy branch 2 times, most recently from b145577 to d00e412 Compare January 12, 2020 01:25
@sikmir
Copy link
Member Author

sikmir commented Jan 12, 2020

Done.

jonringer
jonringer approved these changes Jan 12, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, beside 1 more change

https://github.com/NixOS/nixpkgs/pull/76627
3 package built:
python27Packages.gpxpy python37Packages.gpxpy python38Packages.gpxpy

pkgs/development/python-modules/gpxpy/default.nix Outdated Show resolved Hide resolved
@jonringer jonringer changed the title gpxpy: init at 1.3.5 python3Packages.gpxpy: init at 1.3.5 Jan 12, 2020
@jonringer
Copy link
Contributor

@GrahamcOfBorg build python27Packages.gpxpy python37Packages.gpxpy python38Packages.gpxpy

@jonringer jonringer merged commit 9e9a105 into NixOS:master Jan 12, 2020
@sikmir sikmir deleted the gpxpy branch January 13, 2020 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sikmir @jonringer