Skip to content
This repository was archived by the owner on Apr 12, 2021. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs-channels
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: d85e435b7bde
Choose a base ref
...
head repository: NixOS/nixpkgs-channels
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: c5d5561f772f
Choose a head ref
Loading
Showing with 1,339 additions and 984 deletions.
  1. +1 −1 .github/PULL_REQUEST_TEMPLATE.md
  2. +2 −2 doc/reviewing-contributions.xml
  3. +30 −24 doc/submitting-changes.xml
  4. +3 −3 nixos/modules/services/x11/hardware/libinput.nix
  5. +2 −2 pkgs/applications/gis/qgis/unwrapped.nix
  6. +2 −2 pkgs/applications/misc/diffpdf/default.nix
  7. +8 −8 pkgs/applications/misc/gollum/Gemfile.lock
  8. +14 −14 pkgs/applications/misc/gollum/gemset.nix
  9. +18 −20 pkgs/applications/misc/jekyll/basic/Gemfile.lock
  10. +27 −37 pkgs/applications/misc/jekyll/basic/gemset.nix
  11. +24 −26 pkgs/applications/misc/jekyll/full/Gemfile.lock
  12. +39 −49 pkgs/applications/misc/jekyll/full/gemset.nix
  13. +3 −3 pkgs/applications/networking/browsers/tor-browser-bundle-bin/default.nix
  14. +2 −2 pkgs/applications/networking/instant-messengers/signal-desktop/default.nix
  15. +4 −1 pkgs/applications/networking/instant-messengers/wire-desktop/default.nix
  16. +22 −6 pkgs/applications/networking/instant-messengers/zoom-us/default.nix
  17. +245 −245 pkgs/applications/networking/mailreaders/thunderbird-bin/release_sources.nix
  18. +9 −2 pkgs/applications/science/misc/root/default.nix
  19. +3 −3 pkgs/applications/version-management/gitlab/data.json
  20. +2 −2 pkgs/applications/version-management/gitlab/rubyEnv/Gemfile
  21. +5 −5 pkgs/applications/version-management/gitlab/rubyEnv/Gemfile.lock
  22. +4 −4 pkgs/applications/version-management/gitlab/rubyEnv/gemset.nix
  23. +2 −2 pkgs/applications/version-management/redmine/4.x/Gemfile
  24. +52 −54 pkgs/applications/version-management/redmine/4.x/Gemfile.lock
  25. +2 −2 pkgs/applications/version-management/redmine/4.x/default.nix
  26. +48 −57 pkgs/applications/version-management/redmine/4.x/gemset.nix
  27. +1 −1 pkgs/applications/version-management/redmine/Gemfile
  28. +10 −12 pkgs/applications/version-management/redmine/Gemfile.lock
  29. +2 −2 pkgs/applications/version-management/redmine/default.nix
  30. +18 −27 pkgs/applications/version-management/redmine/gemset.nix
  31. +23 −6 pkgs/applications/virtualization/virtualbox/default.nix
  32. +2 −2 pkgs/applications/virtualization/virtualbox/extpack.nix
  33. +61 −7 pkgs/applications/virtualization/virtualbox/guest-additions/default.nix
  34. +0 −50 pkgs/applications/virtualization/virtualbox/guest-additions/kernel-5.3-fix.patch
  35. +0 −72 pkgs/applications/virtualization/virtualbox/kernel-5.3-fix.patch
  36. +239 −0 pkgs/development/compilers/go/1.13.nix
  37. +34 −0 pkgs/development/compilers/go/remove-test-pie-1.13.patch
  38. +64 −0 pkgs/development/compilers/go/ssl-cert-file-1.13.patch
  39. +4 −4 pkgs/development/interpreters/php/default.nix
  40. +2 −2 pkgs/development/libraries/physics/herwig/default.nix
  41. +2 −2 pkgs/development/libraries/physics/pythia/default.nix
  42. +2 −2 pkgs/development/libraries/physics/thepeg/default.nix
  43. +2 −2 pkgs/development/python-modules/acoustics/default.nix
  44. +2 −2 pkgs/development/python-modules/ansible/default.nix
  45. +2 −2 pkgs/development/python-modules/django/2_2.nix
  46. +8 −3 pkgs/development/tools/clang-tools/default.nix
  47. +20 −0 pkgs/development/tools/clang-tools/wrapper
  48. +2 −2 pkgs/development/tools/continuous-integration/jenkins/default.nix
  49. +2 −2 pkgs/os-specific/linux/dpdk/default.nix
  50. +3 −0 pkgs/os-specific/linux/kernel/common-config.nix
  51. +2 −2 pkgs/os-specific/linux/kernel/linux-4.14.nix
  52. +2 −2 pkgs/os-specific/linux/kernel/linux-4.19.nix
  53. +2 −2 pkgs/os-specific/linux/kernel/linux-4.4.nix
  54. +2 −2 pkgs/os-specific/linux/kernel/linux-4.9.nix
  55. +2 −2 pkgs/os-specific/linux/kernel/linux-5.4.nix
  56. +2 −5 pkgs/os-specific/linux/kernel/linux-libre.nix
  57. +4 −4 pkgs/servers/atlassian/confluence.nix
  58. +0 −135 pkgs/servers/mail/dovecot/2.2.x-module_dir.patch
  59. +165 −0 pkgs/servers/mail/dovecot/2.3.x-module_dir.patch
  60. +3 −3 pkgs/servers/mail/dovecot/default.nix
  61. +2 −2 pkgs/servers/mail/dovecot/plugins/pigeonhole/default.nix
  62. +2 −2 pkgs/servers/mail/spamassassin/default.nix
  63. +4 −4 pkgs/servers/matrix-synapse/default.nix
  64. +3 −3 pkgs/servers/monitoring/grafana/default.nix
  65. +2 −2 pkgs/servers/web-apps/mediawiki/default.nix
  66. +4 −4 pkgs/tools/admin/ansible/default.nix
  67. +15 −2 pkgs/tools/compression/advancecomp/default.nix
  68. +1 −1 pkgs/tools/filesystems/nixpart/0.4/blivet.nix
  69. +5 −5 pkgs/tools/misc/html-proofer/Gemfile.lock
  70. +8 −8 pkgs/tools/misc/html-proofer/gemset.nix
  71. +2 −2 pkgs/tools/networking/aircrack-ng/default.nix
  72. +2 −2 pkgs/tools/networking/dd-agent/datadog-agent.nix
  73. +2 −2 pkgs/tools/networking/wireguard-tools/default.nix
  74. +3 −3 pkgs/tools/package-management/apt/default.nix
  75. +5 −5 pkgs/tools/package-management/{nix-review → nixpkgs-review}/default.nix
  76. +1 −0 pkgs/top-level/aliases.nix
  77. +16 −2 pkgs/top-level/all-packages.nix
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -12,7 +12,7 @@
- [ ] macOS
- [ ] other Linux distributions
- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"`
- [ ] Tested execution of all binary files (usually in `./result/bin/`)
- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
- [ ] Ensured that relevant documentation is up to date
4 changes: 2 additions & 2 deletions doc/reviewing-contributions.xml
Original file line number Diff line number Diff line change
@@ -148,10 +148,10 @@
</listitem>
<listitem>
<para>
The <link xlink:href="https://github.com/Mic92/nix-review">nix-review</link> tool can be used to review a pull request content in a single command. <varname>PRNUMBER</varname> should be replaced by the number at the end of the pull request title. You can also provide the full github pull request url.
The <link xlink:href="https://github.com/Mic92/nixpkgs-review">nixpkgs-review</link> tool can be used to review a pull request content in a single command. <varname>PRNUMBER</varname> should be replaced by the number at the end of the pull request title. You can also provide the full github pull request url.
</para>
<screen>
<prompt>$ </prompt>nix-shell -p nix-review --run "nix-review pr PRNUMBER"
<prompt>$ </prompt>nix-shell -p nixpkgs-review --run "nixpkgs-review pr PRNUMBER"
</screen>
</listitem>
</itemizedlist>
54 changes: 30 additions & 24 deletions doc/submitting-changes.xml
Original file line number Diff line number Diff line change
@@ -290,20 +290,25 @@ Additional information.
</section>

<section xml:id="submitting-changes-tested-compilation">
<title>Tested compilation of all pkgs that depend on this change using <command>nix-review</command></title>
<title>Tested compilation of all pkgs that depend on this change using <command>nixpkgs-review</command></title>

<para>
If you are updating a package's version, you can use nix-review to make sure all packages that depend on the updated package still compile correctly. The <command>nix-review</command> utility can look for and build all dependencies either based on uncommited changes with the <literal>wip</literal> option or specifying a github pull request number.
If you are updating a package's version, you can use nixpkgs-review to make sure all packages that depend on the updated package still compile correctly. The <command>nixpkgs-review</command> utility can look for and build all dependencies either based on uncommited changes with the <literal>wip</literal> option or specifying a github pull request number.
</para>

<para>
review changes from pull request number 12345:
<screen>nix-shell -p nix-review --run "nix-review pr 12345"</screen>
<screen>nix run nixpkgs.nixpkgs-review -c nixpkgs-review pr 12345</screen>
</para>

<para>
review uncommitted changes:
<screen>nix-shell -p nix-review --run "nix-review wip"</screen>
<screen>nix run nixpkgs.nixpkgs-review -c nixpkgs-review wip</screen>
</para>

<para>
review changes from last commit:
<screen>nix run nixpkgs.nixpkgs-review -c nixpkgs-review rev HEAD</screen>
</para>
</section>

@@ -375,31 +380,32 @@ Additional information.

<section xml:id="submitting-changes-master-branch">
<title>Master branch</title>

<itemizedlist>
<listitem>
<para>
It should only see non-breaking commits that do not cause mass rebuilds.
</para>
</listitem>
</itemizedlist>
<para>
The <literal>master</literal> branch is the main development branch.
It should only see non-breaking commits that do not cause mass rebuilds.
</para>
</section>

<section xml:id="submitting-changes-staging-branch">
<title>Staging branch</title>
<para>
The <literal>staging</literal> branch is a development branch where mass-rebuilds go.
It should only see non-breaking mass-rebuild commits.
That means it is not to be used for testing, and changes must have been well tested already.
If the branch is already in a broken state, please refrain from adding extra new breakages.
</para>
</section>

<itemizedlist>
<listitem>
<para>
It's only for non-breaking mass-rebuild commits. That means it's not to be used for testing, and changes must have been well tested already. <link xlink:href="https://web.archive.org/web/20160528180406/http://comments.gmane.org/gmane.linux.distributions.nixos/13447">Read policy here</link>.
</para>
</listitem>
<listitem>
<para>
If the branch is already in a broken state, please refrain from adding extra new breakages. Stabilize it for a few days, merge into master, then resume development on staging. <link xlink:href="http://hydra.nixos.org/jobset/nixpkgs/staging#tabs-evaluations">Keep an eye on the staging evaluations here</link>. If any fixes for staging happen to be already in master, then master can be merged into staging.
</para>
</listitem>
</itemizedlist>
<section xml:id="submitting-changes-staging-next-branch">
<title>Staging-next branch</title>
<para>
The <literal>staging-next</literal> branch is for stabilizing mass-rebuilds submitted to the <literal>staging</literal> branch prior to merging them into <literal>master</literal>.
Mass-rebuilds should go via the <literal>staging</literal> branch.
It should only see non-breaking commits that are fixing issues blocking it from being merged into the <literal>master </literal> branch.
</para>
<para>
If the branch is already in a broken state, please refrain from adding extra new breakages. Stabilize it for a few days and then merge into master.
</para>
</section>

<section xml:id="submitting-changes-stable-release-branches">
6 changes: 3 additions & 3 deletions nixos/modules/services/x11/hardware/libinput.nix
Original file line number Diff line number Diff line change
@@ -209,12 +209,12 @@ in {

services.xserver.config =
''
# General libinput configuration.
# See CONFIGURATION DETAILS section of man:libinput(4).
# Automatically enable the libinput driver for all touchpads.
Section "InputClass"
Identifier "libinputConfiguration"
MatchDriver "libinput"
MatchIsTouchpad "on"
${optionalString (cfg.dev != null) ''MatchDevicePath "${cfg.dev}"''}
Driver "libinput"
Option "AccelProfile" "${cfg.accelProfile}"
${optionalString (cfg.accelSpeed != null) ''Option "AccelSpeed" "${cfg.accelSpeed}"''}
${optionalString (cfg.buttonMapping != null) ''Option "ButtonMapping" "${cfg.buttonMapping}"''}
4 changes: 2 additions & 2 deletions pkgs/applications/gis/qgis/unwrapped.nix
Original file line number Diff line number Diff line change
@@ -10,15 +10,15 @@ let
[ qscintilla-qt5 gdal jinja2 numpy psycopg2
chardet dateutil pyyaml pytz requests urllib3 pygments pyqt5 sip owslib six ];
in mkDerivation rec {
version = "3.10.0";
version = "3.10.1";
pname = "qgis";
name = "${pname}-unwrapped-${version}";

src = fetchFromGitHub {
owner = "qgis";
repo = "QGIS";
rev = "final-${lib.replaceStrings ["."] ["_"] version}";
sha256 = "0qq4dznxxbpj8b4ypkz7dixc0b0v6rmf3c5hs4m3ka3rzck8jsqc";
sha256 = "0xq0nnp7zdqaihqvh5rsi1129g23vnk5ijkpxfzaggafgmhf5hgz";
};

passthru = {
4 changes: 2 additions & 2 deletions pkgs/applications/misc/diffpdf/default.nix
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{ stdenv, fetchurl, fetchpatch, qmake, qttools, qtbase, poppler }:
{ stdenv, mkDerivation, fetchurl, fetchpatch, qmake, qttools, qtbase, poppler }:

stdenv.mkDerivation rec {
mkDerivation rec {
version = "2.1.3";
pname = "diffpdf";

16 changes: 8 additions & 8 deletions pkgs/applications/misc/gollum/Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
GEM
remote: https://rubygems.org/
specs:
charlock_holmes (0.7.6)
charlock_holmes (0.7.7)
diff-lcs (1.3)
gemojione (3.3.0)
json
@@ -29,17 +29,17 @@ GEM
sanitize (~> 2.1.1, >= 2.1.1)
stringex (~> 2.6)
twitter-text (= 1.14.7)
json (2.2.0)
json (2.3.0)
kramdown (1.9.0)
mime-types (3.2.2)
mime-types (3.3)
mime-types-data (~> 3.2015)
mime-types-data (3.2019.0331)
mime-types-data (3.2019.1009)
mini_portile2 (2.4.0)
mustache (0.99.8)
nokogiri (1.10.4)
nokogiri (1.10.7)
mini_portile2 (~> 2.4.0)
posix-spawn (0.3.13)
rack (1.6.11)
rack (1.6.12)
rack-protection (1.5.5)
rack
rouge (2.2.1)
@@ -50,7 +50,7 @@ GEM
rack-protection (~> 1.4)
tilt (>= 1.3, < 3)
stringex (2.8.5)
tilt (2.0.9)
tilt (2.0.10)
twitter-text (1.14.7)
unf (~> 0.1.0)
unf (0.1.4)
@@ -65,4 +65,4 @@ DEPENDENCIES
gollum

BUNDLED WITH
1.17.2
1.17.3
28 changes: 14 additions & 14 deletions pkgs/applications/misc/gollum/gemset.nix
Original file line number Diff line number Diff line change
@@ -4,10 +4,10 @@
platforms = [];
source = {
remotes = ["https://rubygems.org"];
sha256 = "1nf1l31n10yaark2rrg5qzyzcx9w80681449s3j09qmnipsl8rl5";
sha256 = "0hybw8jw9ryvz5zrki3gc9r88jqy373m6v46ynxsdzv1ysiyr40p";
type = "gem";
};
version = "0.7.6";
version = "0.7.7";
};
diff-lcs = {
groups = ["default"];
@@ -89,10 +89,10 @@
platforms = [];
source = {
remotes = ["https://rubygems.org"];
sha256 = "0sx97bm9by389rbzv8r1f43h06xcz8vwi3h5jv074gvparql7lcx";
sha256 = "0nrmw2r4nfxlfgprfgki3hjifgrcrs3l5zvm3ca3gb4743yr25mn";
type = "gem";
};
version = "2.2.0";
version = "2.3.0";
};
kramdown = {
groups = ["default"];
@@ -110,20 +110,20 @@
platforms = [];
source = {
remotes = ["https://rubygems.org"];
sha256 = "0fjxy1jm52ixpnv3vg9ld9pr9f35gy0jp66i1njhqjvmnvq0iwwk";
sha256 = "0g7l18igjb9z7q4b2ykvyxyvjxlx5pwsmx5z3ibdbr6372xgfglk";
type = "gem";
};
version = "3.2.2";
version = "3.3";
};
mime-types-data = {
groups = ["default"];
platforms = [];
source = {
remotes = ["https://rubygems.org"];
sha256 = "1m00pg19cm47n1qlcxgl91ajh2yq0fszvn1vy8fy0s1jkrp9fw4a";
sha256 = "18x61fc36951vw7f74gq8cyybdpxvyg5d0azvqhrs82ddw3v16xh";
type = "gem";
};
version = "3.2019.0331";
version = "3.2019.1009";
};
mini_portile2 = {
groups = ["default"];
@@ -151,10 +151,10 @@
platforms = [];
source = {
remotes = ["https://rubygems.org"];
sha256 = "0nmdrqqz1gs0fwkgzxjl4wr554gr8dc1fkrqjc2jpsvwgm41rygv";
sha256 = "0r0qpgf80h764k176yr63gqbs2z0xbsp8vlvs2a79d5r9vs83kln";
type = "gem";
};
version = "1.10.4";
version = "1.10.7";
};
posix-spawn = {
groups = ["default"];
@@ -171,10 +171,10 @@
platforms = [];
source = {
remotes = ["https://rubygems.org"];
sha256 = "1g9926ln2lw12lfxm4ylq1h6nl0rafl10za3xvjzc87qvnqic87f";
sha256 = "1riq0z408dwvqcqrpq05bp2w879l4sjxzb4cbrbx55kpi6h2g1cj";
type = "gem";
};
version = "1.6.11";
version = "1.6.12";
};
rack-protection = {
dependencies = ["rack"];
@@ -234,10 +234,10 @@
platforms = [];
source = {
remotes = ["https://rubygems.org"];
sha256 = "0ca4k0clwf0rkvy7726x4nxpjxkpv67w043i39saxgldxd97zmwz";
sha256 = "0rn8z8hda4h41a64l0zhkiwz2vxw9b1nb70gl37h1dg2k874yrlv";
type = "gem";
};
version = "2.0.9";
version = "2.0.10";
};
twitter-text = {
dependencies = ["unf"];
38 changes: 18 additions & 20 deletions pkgs/applications/misc/jekyll/basic/Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,28 +1,28 @@
GEM
remote: https://rubygems.org/
specs:
activesupport (6.0.0)
activesupport (6.0.1)
concurrent-ruby (~> 1.0, >= 1.0.2)
i18n (>= 0.7, < 2)
minitest (~> 5.1)
tzinfo (~> 1.1)
zeitwerk (~> 2.1, >= 2.1.8)
addressable (2.6.0)
public_suffix (>= 2.0.2, < 4.0)
zeitwerk (~> 2.2)
addressable (2.7.0)
public_suffix (>= 2.0.2, < 5.0)
colorator (1.1.0)
concurrent-ruby (1.1.5)
em-websocket (0.5.1)
eventmachine (>= 0.12.9)
http_parser.rb (~> 0.6.0)
eventmachine (1.2.7)
ffi (1.11.1)
ffi (1.11.2)
forwardable-extended (2.6.0)
gemoji (3.0.1)
html-pipeline (2.12.0)
html-pipeline (2.12.2)
activesupport (>= 2)
nokogiri (>= 1.4)
http_parser.rb (0.6.0)
i18n (1.6.0)
i18n (1.7.0)
concurrent-ruby (~> 1.0)
jekyll (4.0.0)
addressable (~> 2.4)
@@ -44,7 +44,7 @@ GEM
jekyll-mentions (1.5.1)
html-pipeline (~> 2.3)
jekyll (>= 3.7, < 5.0)
jekyll-sass-converter (2.0.0)
jekyll-sass-converter (2.0.1)
sassc (> 2.0.1, < 3.0)
jekyll-seo-tag (2.6.1)
jekyll (>= 3.3, < 5.0)
@@ -60,33 +60,31 @@ GEM
kramdown-parser-gfm (1.1.0)
kramdown (~> 2.0)
liquid (4.0.3)
listen (3.1.5)
rb-fsevent (~> 0.9, >= 0.9.4)
rb-inotify (~> 0.9, >= 0.9.7)
ruby_dep (~> 1.2)
listen (3.2.0)
rb-fsevent (~> 0.10, >= 0.10.3)
rb-inotify (~> 0.9, >= 0.9.10)
mercenary (0.3.6)
mini_portile2 (2.4.0)
minitest (5.11.3)
nokogiri (1.10.4)
minitest (5.13.0)
nokogiri (1.10.5)
mini_portile2 (~> 2.4.0)
pathutil (0.16.2)
forwardable-extended (~> 2.6)
public_suffix (3.1.1)
public_suffix (4.0.1)
rb-fsevent (0.10.3)
rb-inotify (0.10.0)
ffi (~> 1.0)
rouge (3.9.0)
ruby_dep (1.5.0)
rouge (3.13.0)
safe_yaml (1.0.5)
sassc (2.1.0)
sassc (2.2.1)
ffi (~> 1.9)
terminal-table (1.8.0)
unicode-display_width (~> 1.1, >= 1.1.1)
thread_safe (0.3.6)
tzinfo (1.2.5)
thread_safe (~> 0.1)
unicode-display_width (1.6.0)
zeitwerk (2.1.9)
zeitwerk (2.2.1)

PLATFORMS
ruby
@@ -100,4 +98,4 @@ DEPENDENCIES
jemoji

BUNDLED WITH
1.17.2
1.17.3
Loading