Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iwd: 1.2 -> 1.4 #76577

Merged
merged 2 commits into from Dec 29, 2019
Merged

iwd: 1.2 -> 1.4 #76577

merged 2 commits into from Dec 29, 2019

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Dec 27, 2019

Motivation for this change

https://git.kernel.org/pub/scm/network/wireless/iwd.git/tag/?h=1.4

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 requested a review from fpletz December 27, 2019 15:45
@grahamc
Copy link
Member

grahamc commented Dec 27, 2019

Looking in to the failure.

@grahamc
Copy link
Member

grahamc commented Dec 27, 2019 •
edited

@ofborg eval

@ofborg ofborg bot requested review from dtzWill and Mic92 December 27, 2019 16:58
@fpletz fpletz merged commit ccf839b into NixOS:master Dec 29, 2019
@Ma27 Ma27 deleted the bump-iwd branch December 29, 2019 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz Awaiting requested review from fpletz

@dtzWill dtzWill Awaiting requested review from dtzWill

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @grahamc @fpletz