Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flashplayer: 32.0.0.293 -> 32.0.0.303 #76622

Merged
merged 1 commit into from Dec 28, 2019
Merged

flashplayer: 32.0.0.293 -> 32.0.0.303 #76622

merged 1 commit into from Dec 28, 2019

Conversation

rissson
Copy link
Member

@rissson rissson commented Dec 28, 2019

Motivation for this change

Backporting of #75436
Bug fixes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Only tested with firefox-esr, chromium, and standalone versions.
Firefox 71 does not recognize flash plugins. It is not shown in about:plugins. Neither 32.0.0.293 nor 32.0.0.303 works. Neither firefox-bin nor firefox recognize the plugin. firefox-esr 68.3.0esr works fine with 32.0.0.303.
My old nix-env generation with flashplayer 32.0.0.270 and firefox-bin 70.0.1 work as expected.

Notify maintainers

cc @taku0

@7c6f434c 7c6f434c merged commit 2f6a9e4 into NixOS:release-19.09 Dec 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants