Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.ipykernel: fix build on darwin #76628

Merged
merged 2 commits into from Dec 29, 2019

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Dec 29, 2019

Motivation for this change

Closes: #76197

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Dec 29, 2019
@veprbl
Copy link
Member Author

veprbl commented Dec 29, 2019

@GrahamcOfBorg build python3Packages.ipykernel

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

failures don't seem to be from this bump

[60 built (9 failed), 535 copied (4020.9 MiB), 808.9 MiB DL]
error: build of '/nix/store/8awji19rnc7k2mygdcfg1xw9y40piyag-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/76628
2 package are marked as broken and were skipped:
ihaskell python37Packages.starfish

31 package failed to build:
python37Packages.datashader python37Packages.papermill python37Packages.robotframework-tools python37Packages.runway-python python38Packages.Nikola python38Packages.Pweave python38Packages.ansible-kernel python38Packages.colorcet python38Packages.ipywidgets python38Packages.jupyter python38Packages.jupyterhub python38Packages.jupyterhub-ldapauthenticator python38Packages.jupyterlab python38Packages.jupyterlab_launcher python38Packages.jupyterlab_server python38Packages.kmapper python38Packages.modeled python38Packages.moretools python38Packages.nbconvert python38Packages.nbdime python38Packages.nbsmoke python38Packages.nbsphinx python38Packages.notebook python38Packages.oauthenticator python38Packages.papermill python38Packages.robotframework-tools python38Packages.runway-python python38Packages.scikit-tda python38Packages.spyder python38Packages.widgetsnbextension python38Packages.zetup

50 package were built:
cq-editor jupyter python37Packages.Nikola python37Packages.Pweave python37Packages.ansible-kernel python37Packages.bash_kernel python37Packages.colorcet python37Packages.cufflinks python37Packages.dftfit python37Packages.holoviews python37Packages.hvplot python37Packages.intake python37Packages.ipykernel python37Packages.ipyparallel python37Packages.ipywidgets python37Packages.jupyter python37Packages.jupyter_console python37Packages.jupyterhub python37Packages.jupyterhub-ldapauthenticator python37Packages.jupyterlab python37Packages.jupyterlab_launcher python37Packages.jupyterlab_server python37Packages.kmapper python37Packages.modeled python37Packages.moretools python37Packages.nbconvert python37Packages.nbdime python37Packages.nbsmoke python37Packages.nbsphinx python37Packages.nbval python37Packages.notebook python37Packages.oauthenticator python37Packages.phik python37Packages.pygmo python37Packages.qtconsole python37Packages.scikit-tda spyder python37Packages.spyder-kernels python37Packages.widgetsnbextension python37Packages.zetup python38Packages.bash_kernel python38Packages.ipykernel python38Packages.ipyparallel python38Packages.jupyter_console python38Packages.nbval python38Packages.pygmo python38Packages.qtconsole python38Packages.spyder-kernels sage sageWithDoc

@jonringer jonringer merged commit c69b4f8 into NixOS:master Dec 29, 2019
@jonringer
Copy link
Contributor

although, i want to stabilize the python package set more, but kinda blocked on #76059

@veprbl veprbl deleted the pr/ipykernel_darwin_fix branch December 1, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

python37Packages.ipykernel is broken on darwin
2 participants