New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.ipykernel: fix build on darwin #76628
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All tests pass on NixOS. Some still fail on Darwin, but it's a different issue.
veprbl
force-pushed
the
pr/ipykernel_darwin_fix
branch
from
December 29, 2019 01:14
d692c38
to
241b1fa
Compare
@GrahamcOfBorg build python3Packages.ipykernel |
ofborg
bot
added
6.topic: python
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
labels
Dec 29, 2019
jonringer
approved these changes
Dec 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
failures don't seem to be from this bump
[60 built (9 failed), 535 copied (4020.9 MiB), 808.9 MiB DL]
error: build of '/nix/store/8awji19rnc7k2mygdcfg1xw9y40piyag-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/76628
2 package are marked as broken and were skipped:
ihaskell python37Packages.starfish
31 package failed to build:
python37Packages.datashader python37Packages.papermill python37Packages.robotframework-tools python37Packages.runway-python python38Packages.Nikola python38Packages.Pweave python38Packages.ansible-kernel python38Packages.colorcet python38Packages.ipywidgets python38Packages.jupyter python38Packages.jupyterhub python38Packages.jupyterhub-ldapauthenticator python38Packages.jupyterlab python38Packages.jupyterlab_launcher python38Packages.jupyterlab_server python38Packages.kmapper python38Packages.modeled python38Packages.moretools python38Packages.nbconvert python38Packages.nbdime python38Packages.nbsmoke python38Packages.nbsphinx python38Packages.notebook python38Packages.oauthenticator python38Packages.papermill python38Packages.robotframework-tools python38Packages.runway-python python38Packages.scikit-tda python38Packages.spyder python38Packages.widgetsnbextension python38Packages.zetup
50 package were built:
cq-editor jupyter python37Packages.Nikola python37Packages.Pweave python37Packages.ansible-kernel python37Packages.bash_kernel python37Packages.colorcet python37Packages.cufflinks python37Packages.dftfit python37Packages.holoviews python37Packages.hvplot python37Packages.intake python37Packages.ipykernel python37Packages.ipyparallel python37Packages.ipywidgets python37Packages.jupyter python37Packages.jupyter_console python37Packages.jupyterhub python37Packages.jupyterhub-ldapauthenticator python37Packages.jupyterlab python37Packages.jupyterlab_launcher python37Packages.jupyterlab_server python37Packages.kmapper python37Packages.modeled python37Packages.moretools python37Packages.nbconvert python37Packages.nbdime python37Packages.nbsmoke python37Packages.nbsphinx python37Packages.nbval python37Packages.notebook python37Packages.oauthenticator python37Packages.phik python37Packages.pygmo python37Packages.qtconsole python37Packages.scikit-tda spyder python37Packages.spyder-kernels python37Packages.widgetsnbextension python37Packages.zetup python38Packages.bash_kernel python38Packages.ipykernel python38Packages.ipyparallel python38Packages.jupyter_console python38Packages.nbval python38Packages.pygmo python38Packages.qtconsole python38Packages.spyder-kernels sage sageWithDoc
although, i want to stabilize the python package set more, but kinda blocked on #76059 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: darwin
Running or building packages on Darwin
6.topic: python
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Closes: #76197
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @