New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flacon: improvements #76592
flacon: improvements #76592
Conversation
Hi, I'm using nixos on an headless server only now, so I can't maintain flacon or even test it. Would you mind becoming the maintainer (removing me)? Except for this, thanks for your contribution :) |
Okay, since I'll gotta stick with NixOS on my laptops for a while, I can do that. All I need to do is to add myself to maintainers/maintainer-list.nix and put myself into meta.maintainers? |
yes but do it in separate commits |
Done |
There are some minor problems with commits.
|
1. Use libsForQt5.callPackage instead of raw callPackage` (this adds ability to import qtbase and qttools directly instead of importing whole qt5) 2. Include wrapQtAppsHook in nativeBuildInputs The major point of this changes is to provide support for running support flacon under wayland session, but it may help in some other use cases Closes NixOS#76588
Is it OK now? |
@snglth Thanks for the ping. Yes, this looks good now. |
Thank you! |
flacon: improvements (cherry picked from commit f1d3df9)
ability to import qtbase and qttools directly instead of importing whole
qt5)
Closes #76588
Motivation for this change
The major point of this changes is to provide support for running
support of running flacon under wayland session, but it may help in some
other use cases.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @nico202