treewide: structured-attrs fixes #76674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally introduced in 128901e, it no longer appears to be necessary.
Do not use DESTDIR and bring makeFlags more in line with the Makefile: https://github.com/sembruk/osm2xmap/blob/a5f9ceadf0b06c034850fb22c55f2be4dd43eaef/Makefile
Use makeFlags instead of patching Makefile
* Remove unnecessary linker and compiler flags * Listify makeFlags * Do not use DESTDIR (nasty) * Let generic builder set --prefix configureFlag * Install X11 app-defaults to more modern directory * Format with nixpkgs-fmt
jtojnar
requested review from
adisbladis,
FRidh and
jonringer
as code owners
ofborg
bot
added
6.topic: emacs
6.topic: erlang
6.topic: python
10.rebuild-darwin: 501+
10.rebuild-darwin: 1001-2500
10.rebuild-linux: 501+
10.rebuild-linux: 5001+
10.rebuild-darwin: 11-100
10.rebuild-linux: 101-500
and removed
10.rebuild-darwin: 501+
10.rebuild-darwin: 1001-2500
10.rebuild-linux: 501+
10.rebuild-linux: 5001+
labels
jtojnar
force-pushed
the
structured-attrs-masterable
branch
from
04e3e8f
to
318e1ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes from #72074
that can probably go to master.