Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ffsend: 0.2.57 -> 0.2.58 #76675

Merged
merged 1 commit into from Dec 30, 2019
Merged

ffsend: 0.2.57 -> 0.2.58 #76675

merged 1 commit into from Dec 30, 2019

Conversation

lilyball
Copy link
Member

Motivation for this change

https://github.com/timvisee/ffsend/releases/tag/v0.2.58

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from equirosa December 30, 2019 02:14
@equirosa
Copy link
Contributor

Looks good to me!

@dywedir
Copy link
Member

dywedir commented Dec 30, 2019

Thanks!

@dywedir dywedir merged commit 9ac2382 into NixOS:master Dec 30, 2019
@lilyball lilyball deleted the ffsend branch December 30, 2019 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@equirosa equirosa Awaiting requested review from equirosa

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lilyball @equirosa @dywedir