trenchbroom: init at 2019.6 #76607
trenchbroom: init at 2019.6 #76607
Conversation
|
|
||
| meta = with stdenv.lib; { | ||
| description = "TrenchBroom is a modern cross-platform level editor for Quake-engine based games"; | ||
| homepage = http://kristianduske.com/trenchbroom; |
There was a problem hiding this comment.
Please quote the URL NixOS/rfcs#45
There was a problem hiding this comment.
| homepage = http://kristianduske.com/trenchbroom; | |
| homepage = "http://kristianduske.com/trenchbroom"; |
| cmakeFlags = [ "-DwxWidgets_PREFIX=${wxGTK31}" ]; | ||
| hardeningDisable = [ "format" ]; | ||
|
|
||
| postInstall = "mkdir $out/share/applications; ln -s ../TrenchBroom/trenchbroom.desktop $out/share/applications"; |
There was a problem hiding this comment.
- Use multi line syntax for the
postInstallscript - Consider using
cporinstallinstead ofln
| pname = "TrenchBroom"; | ||
| version = "2019.6"; | ||
|
|
||
| src = fetchgit { |
|
Thank you for your contributions. This has been automatically marked as stale because it has had no activity for 180 days. If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity. Here are suggestions that might help resolve this more quickly:
|
stale
bot
added
the
2.status: stale
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/how-to-run-qt-apps-on-a-build-time-trying-to-pack-trenchbroom/8451/1 |
stale
bot
removed
the
2.status: stale
| }; | ||
|
|
||
| buildInputs = [ mesa mesa_glu freeimage freetype pandoc wxGTK31 libX11 ]; | ||
| nativeBuildInputs = [ cmake git ]; |
There was a problem hiding this comment.
| nativeBuildInputs = [ cmake git ]; | |
| nativeBuildInputs = [ cmake ]; |
If git is fetching some info about the repo please patch that.
| cmakeFlags = [ "-DwxWidgets_PREFIX=${wxGTK31}" ]; | ||
| hardeningDisable = [ "format" ]; | ||
|
|
||
| postInstall = "mkdir $out/share/applications; ln -s ../TrenchBroom/trenchbroom.desktop $out/share/applications"; |
There was a problem hiding this comment.
| postInstall = "mkdir $out/share/applications; ln -s ../TrenchBroom/trenchbroom.desktop $out/share/applications"; | |
| postInstall = '' | |
| mkdir $out/share/applications | |
| cp ../TrenchBroom/trenchbroom.desktop $out/share/applications | |
| ''; |
|
|
||
| meta = with stdenv.lib; { | ||
| description = "TrenchBroom is a modern cross-platform level editor for Quake-engine based games"; | ||
| homepage = http://kristianduske.com/trenchbroom; |
There was a problem hiding this comment.
| homepage = http://kristianduske.com/trenchbroom; | |
| homepage = "http://kristianduske.com/trenchbroom"; |
|
Closing since author did not respond since opening this almost a year ago. Please fix the review comments and ping me and I'll reopen the PR. |
Motivation for this change
This is my first NixOS package, so any constructive feedback would be greatly appreciated!
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)