-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix overflowing nav #122
Fix overflowing nav #122
Conversation
This PR needs more context. "better than now anyway" is a vague statement. In the current version, on my OS and browser, I see no issues with the navigation. So please elaborate what you try to fix. |
holds hands |
Firefox Developer Edition 72.0b10 and Chromium 79.0.3945.88 on Linux. |
I see it too, Arch Linux, Chromium (79) & Firefox (71). Might be something to do with the font loaded? - Trebuchet MS is requested, Chrome says it's loading DejaVu Sans I'd still like to see a "better" solution that removes the need for the left/right navigation divs, but this will do for now. |
Now we are getting to the core of the issue :D I guess Linux doesn't have |
Playing the Advocatus Diaboli (the devils advocate):
That's o.k. in English language, it's o.k. with the intended font sizes and it's o.k., so long as noone want's to introduce translations of the UI with their different word lengths. If one of the assumtions failes, the navigation is vulnerable to overflow again. In the end the site needs a contruction that is able to overflow without breaking design elements like the current background of the navigation. |
It makes it wider than content, but it looks better than now anyway..
Modified it to use flex layout too.