Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixosTests.mysql: add more tests #76606

Merged
merged 2 commits into from Jan 2, 2020
Merged

nixosTests.mysql: add more tests #76606

merged 2 commits into from Jan 2, 2020

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Dec 28, 2019

Motivation for this change

This adds a second mysql user, to make sure ensurePermissions doesn't grant more than necessary.

It also adds some missing () to the start_all command

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @tfc

@flokli
nixosTests.mysql: add missing () to start_all()
7d64f7a 
Because mysql.wait_for_unit() starts the vm as well, we didn't notice
that.
@flokli
nixosTests.mysql: add additional test{db,user}2
bf7841a 
Test that other users are not able to access the mysql database, and
unix socket auth actually works.
@flokli flokli requested a review from grahamc December 31, 2019 10:38
@flokli flokli merged commit 03212a7 into NixOS:master Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andir andir Awaiting requested review from andir

@aanderse aanderse Awaiting requested review from aanderse

@grahamc grahamc Awaiting requested review from grahamc

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@flokli