luckybackup: init at 0.5.0 #76682
luckybackup: init at 0.5.0 #76682
Conversation
| sha256 = "0nwjsk1j33pm8882jbj8h6nxn6n5ab9dxqpqkay65pfbhcjay0g8"; | ||
| }; | ||
|
|
||
| buildInputs = with stdenv.lib; |
There was a problem hiding this comment.
That shouldn't be needed here, right?
There was a problem hiding this comment.
Yeah. I will update my "templates"!
pkgs/top-level/all-packages.nix
Outdated
| @@ -2926,6 +2926,11 @@ in | |||
|
|
|||
| epubcheck = callPackage ../tools/text/epubcheck { }; | |||
|
|
|||
| luckybackup = callPackage ../tools/backup/luckybackup { | |||
| inherit (qt5) qmake; | |||
There was a problem hiding this comment.
Please use libsForQt5.callPackage here. That makes it way easier to add further qt5 deps in the future if needed :)
There was a problem hiding this comment.
It still needs to declare qmake, right?
| sha256 = "0nwjsk1j33pm8882jbj8h6nxn6n5ab9dxqpqkay65pfbhcjay0g8"; | ||
| }; | ||
|
|
||
| buildInputs = [ pkgconfig libtool rsync ssh ]; |
There was a problem hiding this comment.
Please move pkgconfig and libtool to nativeBuildInputs.
|
|
||
| prePatch = '' | ||
| for File in luckybackup.pro menu/luckybackup-pkexec \ | ||
| menu/luckybackup-su.desktop menu/luckybackup.desktop \ |
There was a problem hiding this comment.
Please be consistent with spacing. I think 4 spaces from the prior line would be appropriate here.
| platforms = platforms.linux; | ||
| }; | ||
| } | ||
| # TODO: test in Darwin |
There was a problem hiding this comment.
Please remove. If you need + want someone to test this we can ping some people and see if they will.
|
Done! |
Motivation for this change
New package
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)