Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sourcehut/update-4 #76677

Merged
merged 17 commits into from Feb 15, 2020
Merged

sourcehut/update-4 #76677

merged 17 commits into from Feb 15, 2020

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Dec 30, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review fails on NixOS:

builder for '/nix/store/p3kl7qfmzjc7s7plfr8pj5bh3cva2m9f-python3.7-srht-0.54.4.drv' failed with exit code 1; last 10 log lines:
  adding 'srht-0.54.4.dist-info/RECORD'
  removing build/bdist.linux-x86_64/wheel
  Finished executing setuptoolsBuildPhase
  installing
  Executing pipInstallPhase
  /build/core.sr.ht/dist /build/core.sr.ht
  Processing ./srht-0.54.4-py3-none-any.whl
  Requirement already satisfied: pgpy in /nix/store/plp8hjsrlrjs2ky2vz1qdj4sn0crxbh6-python3.7-pgpy-0.5.2/lib/python3.7/site-packages (from srht==0.54.4) (0.5.1)
  ERROR: Could not find a version that satisfies the requirement flask-login (from srht==0.54.4) (from versions: none)
  ERROR: No matching distribution found for flask-login (from srht==0.54.4)

@eadwu
Copy link
Member Author

eadwu commented Dec 30, 2019

srht should build fine now (probably forgot to cherry-pick the commit), having problems with python3.7-python-hglib-2.6.1 stalling on installCheckPhase now which is unrelated? Otherwise everything else is fine.

@veprbl veprbl mentioned this pull request Feb 4, 2020
10 tasks
@veprbl
Copy link
Member

veprbl commented Feb 10, 2020

@GrahamcOfBorg build sourcehut.buildsrht sourcehut.dispatchsrht sourcehut.gitsrht sourcehut.hgsrht sourcehut.listssrht sourcehut.mansrht sourcehut.metasrht sourcehut.pastesrht sourcehut.todosrht

@veprbl veprbl merged commit 018fac1 into NixOS:master Feb 15, 2020
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Feb 15, 2020
sourcehut/update-4

(cherry picked from commit 018fac1)
@eadwu eadwu deleted the sourcehut/update-4 branch November 17, 2020 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants