Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 4a2621da5370
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: a6bb2ede2329
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Dec 28, 2019

  1. python.pkgs.wrapPython: fix string makeWrapperArgs 

    Bash takes an assignment of a string to an array variable:

local -a user_args
user_args="(foo bar)"

to mean appending the string to the array, not parsing the string into
an array as is the case when on the same line as the declaration:

local -a user_args="(foo bar)"

b063340 extracted the declaration before
the newly branched code block, causing string makeWrapperArgs being added
to the array verbatim.

Since local is function scoped, it does not matter if we move it inside
each of the branches so we fix it this way.
    @jtojnar
    jtojnar committed Dec 28, 2019
    8
    Copy the full SHA
    a6bb2ed View commit details
    Browse the repository at this point in the history