Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python packages.fluidasserts #76597

Closed
wants to merge 24 commits into from
Closed

Python packages.fluidasserts #76597

wants to merge 24 commits into from

Conversation

kamadorueda
Copy link
Member

@kamadorueda kamadorueda commented Dec 28, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@kamadorueda
Copy link
Member Author

is there a way to run those checks made by the grahamcofborg locally ?

- It now works on python2 and python3
- There was another packages called mysql-connector-python that
  was using the name 'mysql-connector', which is the package that
  I'm adding.
- I renamed the old mysql-connector to mysql-connector-python (real
  name)
- And I created a new mysql-connector (real name on PyPi)
- Adjusted references accordingly
@kamadorueda
Copy link
Member Author

Just closing because this is a too big PR, let's bump version updates one-by-one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant