New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python packages.fluidasserts #76597
Closed
kamadorueda
wants to merge
24
commits into
NixOS:master
from
kamadorueda:pythonPackages.fluidasserts
Closed
Python packages.fluidasserts #76597
kamadorueda
wants to merge
24
commits into
NixOS:master
from
kamadorueda:pythonPackages.fluidasserts
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgrade PyYAML to the current stable version - Tested in both python and python3 Closes #76564
is there a way to run those checks made by the grahamcofborg locally ? |
- It now works on python2 and python3
- There was another packages called mysql-connector-python that was using the name 'mysql-connector', which is the package that I'm adding. - I renamed the old mysql-connector to mysql-connector-python (real name) - And I created a new mysql-connector (real name on PyPi) - Adjusted references accordingly
ofborg
bot
requested review from
dotlambda,
primeos,
offlinehacker,
basvandijk,
PsyanticY and
elasticdog
December 28, 2019 10:40
Just closing because this is a too big PR, let's bump version updates one-by-one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @