Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/nixos-installer: add flags for verbosity and build logs #76189

Merged
merged 1 commit into from Dec 28, 2019
Merged

nixos/nixos-installer: add flags for verbosity and build logs #76189

merged 1 commit into from Dec 28, 2019

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Dec 22, 2019

Motivation for this change

When installing a fresh NixOS system it occasionally happens that you
encounter issues that are rather hard to track down since
nixos-install(8) doesn't provide any debugging flags.

This patch adds -L to force nix build to display the build-log on
stderr and -v to increase the log-level of Nix.

Tested whether the installer builds a fresh NixOS in an artifical tmpfs mounted to /mnt as described in the manual.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
nixos/nixos-installer: add flags for verbosity and build logs
1fc248a 
When installing a fresh NixOS system it occasionally happens that you
encounter issues that are rather hard to track down since
`nixos-install(8)` doesn't provide any debugging flags.

This patch adds `-L` to force `nix build` to display the build-log on
stderr and `-v` to increase the log-level of Nix.
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/99

@lheckemann lheckemann merged commit b9bf846 into NixOS:master Dec 28, 2019
@Ma27 Ma27 deleted the nixos-install-verbosity-level branch December 28, 2019 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lheckemann lheckemann lheckemann approved these changes

@grahamc grahamc Awaiting requested review from grahamc

Assignees
No one assigned
Labels
6.topic: nixos 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @nixos-discourse @lheckemann