Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix several broken python packages #76661

Closed
wants to merge 5 commits into from
Closed

Fix several broken python packages #76661

wants to merge 5 commits into from

Conversation

costrouc
Copy link
Member

Motivation for this change

qutip takes 2 hours to run tests... what would be a better way? Otherwise full test suite enabled on broken packages and all tests pass.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from cstrahan December 29, 2019 22:14
@costrouc costrouc mentioned this pull request Dec 30, 2019
Closed
@costrouc
Copy link
Member Author

I opened an issue with qutip asking what would be the recommended subset of tests to run such that we can have it complete a build in around 10 minutes. qutip/qutip#1147.

@akirakyle
Copy link

Any progress on this? It looks like qutip moved testing to pytest and have a faster subset of tests that can be run.

@tobiasBora
Copy link
Contributor

Any update on that? I would need qutip.

@jonringer
Copy link
Contributor

discordpy qutip and sparse have already been bumped, not sure about the other two

@tobiasBora
Copy link
Contributor

What do you mean by bumped? You mean removed from nixpkgs? If yes any idea why? I'm thinking to bring qutip back.

@jonringer
Copy link
Contributor

bumped means updated or brought attention to

they have not been removed

also, this PR is very old by python standards. We should probably close

@stale
Copy link

stale bot commented Jun 7, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 7, 2021
@jonringer
Copy link
Contributor

this has conflicts with most packages. going to close

@jonringer jonringer closed this Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@FRidh FRidh Awaiting requested review from FRidh

@cstrahan cstrahan Awaiting requested review from cstrahan

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@costrouc @akirakyle @tobiasBora @jonringer @ryantm