mautrix-telegram: 0.6.1 -> 0.7.0 #76603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously known as `mautrix-appservice`. For backwards-compatibility, I added an alias in `python-packages.nix`. Additionally a small patch was needed which I already filed upstream[1]. Please note that the package switched from a MIT license to the Mozilla Public License[2]. [1] mautrix/python#13 [2] https://github.com/tulir/mautrix-python/blob/v0.4.0/LICENSE
https://github.com/tulir/mautrix-telegram/releases/tag/v0.7.0 https://github.com/tulir/mautrix-telegram/releases/tag/v0.7.0-rc4 https://github.com/tulir/mautrix-telegram/releases/tag/v0.7.0-rc3 https://github.com/tulir/mautrix-telegram/releases/tag/v0.7.0-rc2 https://github.com/tulir/mautrix-telegram/releases/tag/v0.7.0-rc1
jonringer
approved these changes
Dec 29, 2019
There was a problem hiding this comment.
LGTM
failures not related to PR
[6 built (1 failed), 8 copied (5.6 MiB), 0.8 MiB DL]
error: build of '/nix/store/ly5qlnciv2ygnvxpkvyarwxwpda6xvwm-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/76603
1 package failed to build:
python38Packages.mautrix
2 package were built:
mautrix-telegram python37Packages.mautrix
|
please address darwin issue, or limit platforms to only linux :) |
Tests currently fail like this:
```
/nix/store/yslk7x7iw3hka6d33kmnba9sxaia4492-python3.7-mautrix-0.4.0/lib/python3.7/site-packages/mautrix/util/manhole.py:9: in <module>
from socket import SOL_SOCKET, SO_PEERCRED
E ImportError: cannot import name 'SO_PEERCRED' from 'socket' (/nix/store/81qani7sdir46gjwf3a3jr2cv1aggkz1-python3-3.7.5/lib/python3.7/socket.py)
!!!!!!!!!!!!!!!!!!! Interrupted: 1 errors during collection !!!!!!!!!!!!!!!!!!!!
=============================== 1 error in 1.73s ===============================
```
Those values don't seem to be available on the MacOS-version of that
module. As there's no workaround implemented in the source, I assume
that upstream doesn't intend to support darwin-alike platforms atm.
|
@jonringer fixed (explanation is in the body of the commit message :)) |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Updates
mautrix-telegramto 0.7.0.The dependency
mautrix-appservicewas updated to 0.4.0 and was renamed tomautrix.python3Packages.mautrixchanged from MIT to MPL2.Final notes:
python3Packages.telethonto 1.10.9 in your fork to make it work).Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @nyanloutre @pacien