Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/displayManager: fix typo in legacy sessions #76626

Merged
merged 1 commit into from Dec 29, 2019
Merged

nixos/displayManager: fix typo in legacy sessions #76626

merged 1 commit into from Dec 29, 2019

Conversation

hedning
Copy link
Contributor

@hedning hedning commented Dec 28, 2019

Motivation for this change
Things done

xsession gets passed dm wm, so the desktop manager would be launched
before the window manager resulting in a regular desktop manager
session.

Fixes #76625

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@hedning
nixos/displayManager: fix typo in legacy sessions
1cc0e3b 
xsession gets passed `dm` `wm`, so the desktop manager would be launched
before the window manager resulting in a regular desktop manager
session.

Fixes NixOS#76625
Kiwi
Kiwi approved these changes Dec 29, 2019
View reviewed changes
Copy link
Member

@Kiwi Kiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works! Thank you

@hedning hedning merged commit 3d70d4b into NixOS:master Dec 29, 2019
@hedning hedning deleted the fix-legacy-sessions branch December 29, 2019 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kiwi Kiwi Kiwi approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

plasma5+xmonad no longer works after nixos/displayManager: introduce defaultSession #53843
2 participants
@hedning @Kiwi