Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emplace: 0.2.8 -> 0.2.10 #76581

Merged
merged 2 commits into from Jan 9, 2020
Merged

emplace: 0.2.8 -> 0.2.10 #76581

merged 2 commits into from Jan 9, 2020

Conversation

Br1ght0ne
Copy link
Member

@Br1ght0ne Br1ght0ne commented Dec 27, 2019

Motivation for this change

https://github.com/tversteeg/emplace/releases/tag/v0.2.9
https://github.com/tversteeg/emplace/releases/tag/v0.2.10

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
/nix/store/gh4527ywcsiavricyb399dymsw5ph9m7-emplace-0.2.8	  29.8M
/nix/store/zzd7227m0f6i0y6cln1mj8m68zq1w64a-emplace-0.2.9     30.1M
/nix/store/4irn6v5iy6mp5sr4ci4r6lcrvpq3s133-emplace-0.2.10    30.1M

This change is Reviewable

Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs on NixOS. did not test. It would be great if the tool somehow supported Nix. But that's an upstream concern.

@Br1ght0ne Br1ght0ne changed the title emplace: 0.2.8 -> 0.2.9 emplace: 0.2.8 -> 0.2.10 Jan 6, 2020
@Br1ght0ne
Copy link
Member Author

@GrahamcOfBorg build emplace

@c0bw3b c0bw3b merged commit 7d93381 into NixOS:master Jan 9, 2020
@Br1ght0ne Br1ght0ne deleted the emplace-0.2.9 branch January 9, 2020 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants