Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rubyMinimal: fix build #76649

Merged
merged 1 commit into from Dec 30, 2019
Merged

rubyMinimal: fix build #76649

merged 1 commit into from Dec 30, 2019

Conversation

alyssais
Copy link
Member

Motivation for this change

rubyMinimal has been failing since we upgraded RubyGems because it started assuming the presence of OpenSSL.

Patch has been submitted to RubyGems but not yet accepted: rubygems/rubygems#3059

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@alyssais
rubygems: fix for Ruby with no openssl
a93eacb 
This fixes the rubyMinimal package.
@alyssais
Copy link
Member Author

@GrahamcOfBorg build ruby rubyMinimal

@ofborg ofborg bot added the 6.topic: ruby label Dec 29, 2019
@ofborg ofborg bot requested review from manveru and vrthra December 29, 2019 18:52
@FRidh FRidh added this to Ready in Staging Dec 30, 2019
@FRidh FRidh changed the base branch from master to staging December 30, 2019 15:11
@FRidh FRidh merged commit a08e566 into NixOS:staging Dec 30, 2019
Staging automation moved this from Ready to Done Dec 30, 2019
@andersk andersk mentioned this pull request Dec 31, 2019
Merged
10 tasks
andersk referenced this pull request Dec 31, 2019
@Profpatsch
rubyMinimal: ruby with all options disabled by default
7d4c1ae 
Similar to `gitMinimal` or `pythonMinimal`, this is useful for scripts
which don’t use anything but the standard library and want a small
footprint.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm Awaiting requested review from zimbatm

@Profpatsch Profpatsch Awaiting requested review from Profpatsch

@manveru manveru Awaiting requested review from manveru

@vrthra vrthra Awaiting requested review from vrthra

Assignees
No one assigned
Labels
6.topic: ruby 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alyssais @FRidh