Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.compiledb: init at 0.10.1 + dependencies #76654

Merged
merged 3 commits into from Jan 3, 2020
Merged

pythonPackages.compiledb: init at 0.10.1 + dependencies #76654

merged 3 commits into from Jan 3, 2020

Conversation

multun
Copy link
Member

@multun multun commented Dec 29, 2019 •
edited

Motivation for this change

I need compiledb to run some proprietary software

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

costrouc
costrouc suggested changes Dec 29, 2019
View reviewed changes
pkgs/development/python-modules/bashlex/default.nix Show resolved Hide resolved
pkgs/development/python-modules/compiledb/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/compiledb/default.nix Show resolved Hide resolved
pkgs/development/python-modules/bashlex/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/compiledb/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/shutilwhich/default.nix Show resolved Hide resolved
pkgs/development/python-modules/shutilwhich/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/shutilwhich/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
@multun multun force-pushed the compiledb branch 2 times, most recently from 55bccd8 to 21d5874 Compare December 29, 2019 20:12
@multun
Copy link
Member Author

multun commented Dec 29, 2019

@costrouc thanks for the review :)

@costrouc
Copy link
Member

costrouc commented Dec 29, 2019 •
edited

Nix review passes. Would still like to see that package names alphabetized in python-packages.nix. Otherwise LGTM.

Result of nix-review pr 76654 1

9 package were built:
  • python27Packages.bashlex
  • python27Packages.compiledb
  • python27Packages.shutilwhich
  • python37Packages.bashlex
  • python37Packages.compiledb
  • python37Packages.shutilwhich
  • python38Packages.bashlex
  • python38Packages.compiledb
  • python38Packages.shutilwhich

@dtzWill
Copy link
Member

dtzWill commented Jan 1, 2020

Neat, thanks for the PR!

Kicking the tires a bit, noticed something that seems undesired:

$ /nix/store/f0191y6jz8zqcx119yvy9xs2by9nd8xj-python3.7-compiledb-0.10.1/bin/compiledb --help
Unable to create '/nix/store/3isgyj3nyp7zjsp4i6np1q1fxqyrsw49-python3.7-bashlex-0.14/lib/python3.7/site-packages/bashlex/parsetab.py'
[Errno 30] Read-only file system: '/nix/store/3isgyj3nyp7zjsp4i6np1q1fxqyrsw49-python3.7-bashlex-0.14/lib/python3.7/site-packages/bashlex/parsetab.py'

Is this a problem, can it be fixed?

@multun
Copy link
Member Author

multun commented Jan 1, 2020

@dtzWill it's not a huge problem but there's definitely room for improvement here. I'll fix it

@multun
Copy link
Member Author

multun commented Jan 2, 2020

@dtzWill the warning shouldn't be there anymore, thanks for the report :)

@multun
Copy link
Member Author

multun commented Jan 2, 2020

Would still like to see that package names alphabetized in python-packages.nix. Otherwise LGTM.

Done, thanks!

jonringer
jonringer approved these changes Jan 3, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commits LGTM
has tests for each package 👍
repo's look active enough

[13 built, 5 copied (1.0 MiB), 0.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/76654
9 package built:
python27Packages.bashlex python27Packages.compiledb python27Packages.shutilwhich python37Packages.bashlex python37Packages.compiledb python37Packages.shutilwhich python38Packages.bashlex python38Packages.compiledb python38Packages.shutilwhich

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python27Packages.bashlex python27Packages.compiledb python27Packages.shutilwhich python37Packages.bashlex python37Packages.compiledb python37Packages.shutilwhich python38Packages.bashlex python38Packages.compiledb python38Packages.shutilwhich

@jonringer jonringer merged commit 16c6659 into NixOS:master Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@costrouc costrouc costrouc requested changes

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@multun @costrouc @dtzWill @jonringer