Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.fsspec: 0.5.2 -> 0.6.2 enable tests #76664

Merged
merged 4 commits into from Dec 30, 2019
Merged

python3Packages.fsspec: 0.5.2 -> 0.6.2 enable tests #76664

merged 4 commits into from Dec 30, 2019

Conversation

costrouc
Copy link
Member

@costrouc costrouc commented Dec 29, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from tbenst December 30, 2019 13:52
@costrouc
Copy link
Member Author

Nix review passes. rl-coach was broken before this PR and it looks non trivial to fix

Result of nix-review pr 76664 1

1 package failed to build:
  • python37Packages.rl-coach
31 package were built:
  • python27Packages.diskcache
  • python37Packages.aplpy
  • python37Packages.caffe
  • python37Packages.dask
  • python37Packages.dask-glm
  • python37Packages.dask-image
  • python37Packages.dask-jobqueue
  • python37Packages.dask-ml
  • python37Packages.dask-mpi
  • python37Packages.dask-xgboost
  • python37Packages.datashader
  • python37Packages.diskcache
  • python37Packages.distributed
  • python37Packages.fsspec
  • python37Packages.glymur
  • python37Packages.image-match
  • python37Packages.imagecodecs-lite
  • python37Packages.intake
  • python37Packages.pims
  • python37Packages.pyfftw
  • python37Packages.scikitimage
  • python37Packages.slicedimage
  • python37Packages.streamz
  • python37Packages.stumpy
  • python37Packages.stytra
  • python37Packages.sunpy
  • python37Packages.tifffile
  • python38Packages.diskcache
  • python38Packages.fsspec
  • python38Packages.imagecodecs-lite
  • python38Packages.tifffile

@FRidh FRidh merged commit 3af601f into NixOS:master Dec 30, 2019
@tbenst
Copy link
Contributor

tbenst commented Dec 30, 2019

This is going to a cause a merge conflict with #76059 on tifffile and imagecodecs-lite. Looks like this adds python2 support which is nice

@costrouc @FRidh

@jonringer
Copy link
Contributor

@tbenst it was deconflicted here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@tbenst tbenst Awaiting requested review from tbenst

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@costrouc @tbenst @jonringer @FRidh