Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alure2: init at unstable-2019-09-21 #76635

Merged
merged 2 commits into from Jan 12, 2020
Merged

alure2: init at unstable-2019-09-21 #76635

merged 2 commits into from Jan 12, 2020

Conversation

McSinyx
Copy link
Member

@McSinyx McSinyx commented Dec 29, 2019

Motivation for this change

I am trying to add the new major release of alure, which has C++11 API instead of the previous C API. This should not replace alure 1 since the two are incompatible.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Tested compilation and usage of examples
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

aanderse
aanderse requested changes Jan 11, 2020
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Thanks for contributing a new package to nixpkgs! We're especially excited you want to join the team and maintain the package 🎉

The package looks good. Just a minor nitpick or two. I'll build this once I get a chance and we can get this merged.

pkgs/development/libraries/alure2/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/alure2/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/alure2/default.nix Outdated Show resolved Hide resolved
@McSinyx
Copy link
Member Author

McSinyx commented Jan 11, 2020

Thank you for the review, I've updated the nix file accordingly.

aanderse
aanderse approved these changes Jan 11, 2020
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks again 🎉

@aanderse
Copy link
Member

Ah sorry... @McSinyx I forgot, you're supposed to add yourself to the list of maintainers in a separate commit! Please do that and then we're ready to merge. Thanks!

@McSinyx
Copy link
Member Author

McSinyx commented Jan 12, 2020

Thanks, I've separated the change into 2 commits.

@aanderse aanderse merged commit cac169e into NixOS:master Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@McSinyx @aanderse