Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOM Overlay: update API to match current draft spec #20928

Merged
merged 1 commit into from Jan 14, 2020

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Dec 27, 2019

The current draft spec https://immersive-web.github.io/dom-overlays/ has
several API shape changes compared to the currently-implemented
prototype, and this CL updates the implementation to match the new API.

Instead of asking applications to use the Fullscreen API to change
the active DOM overlay element, use a separate initialization dictionary
to configure this at session creation time, and make that unmodifiable
from that point on until the session ends.

Also add a domOverlayState XRSession attribute that shows that the
mode is working (this isn't obvious if it was requested as an optional
feature), and also the type of overlay (screen or floating).

This change is part of a series. The following parts are logically also
part of the API update, but split out to keep the size more manageable.
The next steps include renaming the feature name and implementing the
new event deduplication logic.

Bug: 991747
Change-Id: I032fba53f0180d791b0999ed93393bfb4467b3cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974596
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Piotr Bialecki <bialpio@chromium.org>
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731443}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1974596 branch 3 times, most recently from 9b39c7a to beef225 Compare January 1, 2020 00:30
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1974596 branch 5 times, most recently from 659fca5 to 9b8b86a Compare January 13, 2020 20:30
The current draft spec https://immersive-web.github.io/dom-overlays/ has
several API shape changes compared to the currently-implemented
prototype, and this CL updates the implementation to match the new API.

Instead of asking applications to use the Fullscreen API to change
the active DOM overlay element, use a separate initialization dictionary
to configure this at session creation time, and make that unmodifiable
from that point on until the session ends.

Also add a domOverlayState XRSession attribute that shows that the
mode is working (this isn't obvious if it was requested as an optional
feature), and also the type of overlay (screen or floating).

This change is part of a series. The following parts are logically also
part of the API update, but split out to keep the size more manageable.
The next steps include renaming the feature name and implementing the
new event deduplication logic.

Bug: 991747
Change-Id: I032fba53f0180d791b0999ed93393bfb4467b3cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974596
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Piotr Bialecki <bialpio@chromium.org>
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731443}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants