Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yeetgif: init at 1.23.5 #76647

Merged
merged 1 commit into from Dec 30, 2019
Merged

yeetgif: init at 1.23.5 #76647

merged 1 commit into from Dec 30, 2019

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Dec 29, 2019

Motivation for this change

I'm using this tool.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Lassulus

@ofborg ofborg bot requested a review from ehmry December 29, 2019 22:33
Lassulus
Lassulus approved these changes Dec 30, 2019
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-shell

gif emoji "ok hand sign" | gif roll

@Lassulus Lassulus merged commit 863794c into NixOS:master Dec 30, 2019
@ajs124 ajs124 deleted the init/yeetgif branch January 5, 2020 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Lassulus approved these changes

@ehmry ehmry Awaiting requested review from ehmry

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ajs124 @Lassulus