Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rdbtools: init at 0.1.14 #68631

Merged
merged 2 commits into from Dec 29, 2019
Merged

rdbtools: init at 0.1.14 #68631

merged 2 commits into from Dec 29, 2019

Conversation

offlinehacker
Copy link
Contributor

Motivation for this change

Package rdbtools

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@offlinehacker
Copy link
Contributor Author

Fixed eval error, should be good now

jonringer
jonringer reviewed Dec 13, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably future proofing, but only referencing the python interpreter allows better flexibility with overrides

pkgs/development/tools/rdbtools/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/rdbtools/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/rdbtools/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/rdbtools/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@offlinehacker offlinehacker force-pushed the pkgs/rdbtools/init branch 2 times, most recently from 108ebef to 3f6cfe8 Compare December 13, 2019 09:43
@offlinehacker
Copy link
Contributor Author

Ok, i implemented suggested changes. Also using default version of python works just fine, so no need to pass python3.

@jonringer
Copy link
Contributor

i would highly recommend python3, python2 is EOL in 2 weeks

@offlinehacker
Copy link
Contributor Author

Ok, but works both with both versions, so when we change the default version to python3 it should work without any change. I was just thinking to leave it as is, so you do need python3 on system if only using this package.

@offlinehacker
Copy link
Contributor Author

Ok, i set python3 explicitly, should be ready to merge now.

@jonringer
Copy link
Contributor

jonringer commented Dec 13, 2019 •
edited

Ok, but works both with both versions, so when we change the default version to python3 it should work without any change. I was just thinking to leave it as is, so you do need python3 on system if only using this package.

It would be the same thing with python2, the python closure in nixpkgs is ~110MB, and it get's "reused" by many other packages, so it's actual cost is quite amortized.

jonringer
jonringer approved these changes Dec 13, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commits LGTM

[7 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/68631
4 package were built:
python27Packages.python-lzf python37Packages.python-lzf python38Packages.python-lzf rdbtools

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python27Packages.python-lzf python37Packages.python-lzf python38Packages.python-lzf rdbtools

@offlinehacker offlinehacker merged commit 3da80f0 into NixOS:master Dec 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@offlinehacker @jonringer