Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ruby_2_4: remove #76600

Closed
wants to merge 1 commit into from
Closed

ruby_2_4: remove #76600

wants to merge 1 commit into from

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Dec 28, 2019

According to https://endoflife.software/programming-languages/server-side-scripting/ruby
ruby 2.4 will go end-of-life in march, where the new release of nixpkgs
will be cut. We won't be able to support it for security updates.

Remove all references to ruby_2_4 and add ruby_2_7 instead where
missing.

Mark packages that depend on ruby 2.4 as broken:

  • chefdk
  • sonic-pi
Motivation for this change

rubyPackages_2_4.libv8 was breaking in #76595 which prompted me to look at the ruby situation.

Ruby 2.4 will be EOL for our next release. We also have a policy of keeping only 3 versions of the same thing in nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @alyssais @manveru

@alyssais
Copy link
Member

We also have a policy of keeping only 3 versions of the same thing in nixpkgs.

We do?

@zimbatm
Copy link
Member Author

zimbatm commented Dec 28, 2019

Maybe policy is too strong of a word. It's a number I have seen in multiple places (don't have the sources right now). Typically libraries would have between 1 and 2, with a strong bias towards 1. Programs between 1-3. Programming languages, around 3.

alyssais
alyssais previously approved these changes Dec 28, 2019
View reviewed changes
Copy link
Member

@alyssais alyssais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t have strong feelings about doing this now or in a few months.

@alyssais
Copy link
Member

Actually, I think we should hold off. People might be, say, using 2.4 at work and not upgraded yet, with a schedule to do so before EOL (I was in this situation with 2.3 last year). I think maybe we should give them until a little closer to the deadline.

@zimbatm
Copy link
Member Author

zimbatm commented Dec 28, 2019

that's fine, they can stay on 19.09 for a bit longer

@alyssais
Copy link
Member

alyssais commented Dec 29, 2019 via email

@FRidh
Copy link
Member

FRidh commented Dec 30, 2019

We also keep Python 2.7, despite it going EOL. It should however be possible to disable the derivation if issues come up that we cannot resolve.

@FRidh FRidh added this to WIP in Staging via automation Dec 30, 2019
@zimbatm
Copy link
Member Author

zimbatm commented Dec 30, 2019

in that case the bits that add ruby 2.7 should probably be cherry-picked out of this PR

@alyssais
Copy link
Member

alyssais commented Jan 1, 2020 via email

@alyssais alyssais mentioned this pull request Jan 1, 2020
Merged
10 tasks
@timokau timokau dismissed alyssais’s stale review January 23, 2020 20:13

Comment indicates that approval is out of date.

@worldofpeace worldofpeace mentioned this pull request Feb 9, 2020
Closed
@worldofpeace worldofpeace added this to the 20.03 milestone Feb 9, 2020
@worldofpeace
Copy link
Contributor

Marking sonic-pi as broken here is fine, just read sonic-pi-net/sonic-pi#2179 (comment) and you'll get the idea.

@zimbatm @worldofpeace
ruby_2_4: remove
1b5d37a 
According to https://endoflife.software/programming-languages/server-side-scripting/ruby
ruby 2.4 will go end-of-life in march, where the new release of nixpkgs
will be cut. We won't be able to support it for security updates.

Remove all references to ruby_2_4 and add ruby_2_7 instead where
missing.

Mark packages that depend on ruby 2.4 as broken:
* chefdk
* sonic-pi
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg eval

@worldofpeace
Copy link
Contributor

Merged to staging in bcdc90a. We need to port this to release-20.03, will do this once we have a release staging branch. cc @vcunat @FRidh

Staging automation moved this from WIP to Done Feb 10, 2020
@ofborg ofborg bot requested a review from manveru February 10, 2020 18:35
@zimbatm zimbatm deleted the remove-ruby-2.4 branch February 11, 2020 20:32
@vcunat
Copy link
Member

vcunat commented Feb 12, 2020

For reference, done as f8f607b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais alyssais left review comments

@kamilchm kamilchm Awaiting requested review from kamilchm

@vrthra vrthra Awaiting requested review from vrthra

@Izorkin Izorkin Awaiting requested review from Izorkin

@elitak elitak Awaiting requested review from elitak

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

@Phlogistique Phlogistique Awaiting requested review from Phlogistique

@manveru manveru Awaiting requested review from manveru

Assignees
No one assigned
Labels
6.topic: ruby 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
Staging
  
Done
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@zimbatm @alyssais @FRidh @worldofpeace @vcunat @manveru