Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vbam: add wxWidgets GUI #76617

Closed
wants to merge 3 commits into from
Closed

vbam: add wxWidgets GUI #76617

wants to merge 3 commits into from

Conversation

aske
Copy link
Member

@aske aske commented Dec 28, 2019 •
edited

Motivation for this change

Add a wxWidgets GUI with a working GBA link.
Had to update vbam to the latest git revision, because GBA link wasn't building on the latest 2.1.4 release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from Lassulus December 28, 2019 17:23
@Lassulus
Copy link
Member

I would prefer to wait for a new stable release

@stale
Copy link

stale bot commented Jun 27, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 27, 2020
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 3, 2020
@stale
Copy link

stale bot commented Jun 7, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 7, 2021
@NorfairKing
Copy link
Contributor

Just FYI: I got this building with wxGTK31 and the latest release instead. Thanks for opening this PR, even if it didn't get merged.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 8, 2021
SuperSandro2000
SuperSandro2000 reviewed Nov 12, 2021
View reviewed changes
pkgs/misc/emulators/vbam/default.nix
}:

stdenv.mkDerivation rec {
pname = "visualboyadvance-m";
version = "2.1.4";
version = "2019-12-26";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version = "2019-12-26";
version = "unstable-2019-12-26";

SuperSandro2000
SuperSandro2000 requested changes Nov 12, 2021
View reviewed changes
pkgs/misc/emulators/vbam/default.nix
Comment on lines +51 to +55
] ++ (if !enableWx
then [ "-DENABLE_WX='false'"
"-DENABLE_SDL='true'"
]
else [ "-DENABLE_WX='true'" ]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
] ++ (if !enableWx
then [ "-DENABLE_WX='false'"
"-DENABLE_SDL='true'"
]
else [ "-DENABLE_WX='true'" ]);
] ++ (if !enableWx
then [ "-DENABLE_WX='false'"
"-DENABLE_SDL='true'"
] else [
"-DENABLE_WX='true'"
]);

pkgs/misc/emulators/vbam/default.nix
description = "A merge of the original Visual Boy Advance forks";
license = licenses.gpl2;
maintainers = with maintainers; [ lassulus ];
homepage = http://vba-m.com/;
platforms = stdenv.lib.platforms.linux;
platforms = lib.platforms.linux;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
platforms = lib.platforms.linux;
platforms = platforms.linux;

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 19, 2022
@AndersonTorres
Copy link
Member

Closing as essentially dead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@Lassulus Lassulus Awaiting requested review from Lassulus

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@aske @Lassulus @NorfairKing @AndersonTorres @SuperSandro2000 @ryantm