Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenSC: 0.19.0 -> 0.20.0 #76666

Merged
merged 1 commit into from Dec 31, 2019
Merged

OpenSC: 0.19.0 -> 0.20.0 #76666

merged 1 commit into from Dec 31, 2019

Conversation

raboof
Copy link
Member

@raboof raboof commented Dec 29, 2019 •
edited by veprbl

Motivation for this change

Fixes: #76665
Addresses #76013 on master

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @erictapen

@raboof raboof mentioned this pull request Dec 29, 2019
Closed
@erictapen
Copy link
Member

Thanks! For this easy kind of backport you could just state it in the description of the PR, that it needs to be backported to release-19.09.

Also this closes #76013 due to the release notes.

erictapen
erictapen requested changes Dec 29, 2019
View reviewed changes
pkgs/tools/security/opensc/default.nix Outdated Show resolved Hide resolved
@erictapen
Copy link
Member

Great! Now please squash these two commits into one, e.g. with git rebase -i master.

@erictapen
Copy link
Member

@GrahamcOfBorg build opensc

@ofborg ofborg bot requested a review from erictapen December 29, 2019 23:37
@veprbl veprbl added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Dec 30, 2019
@veprbl
Copy link
Member

veprbl commented Dec 30, 2019

@GrahamcOfBorg build opensc
@GrahamcOfBorg build qdigidoc rng-tools libdigidocpp
@GrahamcOfBorg build chrome-token-signing

@veprbl veprbl merged commit a436604 into NixOS:master Dec 31, 2019
@erictapen
Copy link
Member

@raboof Thanks!
@veprbl I'd rather have this backported than having #76724 merged. What do you think?

@veprbl
Copy link
Member

veprbl commented Dec 31, 2019

@erictapen If you think that's more appropriate, then sure. You need to cherry-pick (don't forget -X option), open a new PR against release-19.09, test that nothing is broken.

@erictapen erictapen mentioned this pull request Dec 31, 2019
Merged
10 tasks
@erictapen
Copy link
Member

@veprbl I just opened #76727. Yeah, I think it might make more sense to bump the package than to cherry-pick all the CVE fixes. But let's wait what the tests say.
Thanks for the effort anyway.

veprbl pushed a commit that referenced this pull request Dec 31, 2019
@erictapen @veprbl
opensc: 0.19.0 -> 0.20.0 (#76666)
2f3bbb5 
(cherry picked from commit a436604)
@TredwellGit TredwellGit added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erictapen erictapen erictapen approved these changes

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpenSC is not reproducible
4 participants
@raboof @erictapen @veprbl @TredwellGit