Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kmymoney: fix build #76613

Merged
merged 1 commit into from Dec 28, 2019
Merged

kmymoney: fix build #76613

merged 1 commit into from Dec 28, 2019

Conversation

alyssais
Copy link
Member

Motivation for this change

python2 used to be propagated in here, until 4e421ae (cc @grahamc).

Upstream bug to stop using Python 2: https://bugs.kde.org/show_bug.cgi?id=405383

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais
kmymoney: fix build
53c4668 
python2 used to be propagated in here, until
4e421ae.

Upstream bug to stop using Python 2:
https://bugs.kde.org/show_bug.cgi?id=405383
@Ma27 Ma27 merged commit a9e86bb into NixOS:master Dec 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alyssais @Ma27