Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iosevka: 2.3.2 -> 2.3.3 #76612

Merged
merged 1 commit into from Jan 9, 2020
Merged

iosevka: 2.3.2 -> 2.3.3 #76612

merged 1 commit into from Jan 9, 2020

Conversation

vincentbernat
Copy link
Member

Motivation for this change

Update Iosevka to latest version. I have also updated package.json versions when a version matching the constraint was already present in nixpkgs. This is not the case with otfcc-ttcize. I don't know if there are tools to help this kind of update (or if this is necessary). Compared to upstream package.json file, there are dependencies missing, but they were already missing in 2.3.2.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @babariviere, @rileyinman

babariviere
babariviere approved these changes Dec 28, 2019
View reviewed changes
Copy link
Member

@babariviere babariviere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

rileyinman
rileyinman approved these changes Dec 29, 2019
View reviewed changes
Copy link
Contributor

@rileyinman rileyinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well.

@c0bw3b c0bw3b merged commit ef42963 into NixOS:master Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@babariviere babariviere babariviere approved these changes

@rileyinman rileyinman rileyinman approved these changes

@ttuegel ttuegel Awaiting requested review from ttuegel

@cstrahan cstrahan Awaiting requested review from cstrahan

@jfrankenau jfrankenau Awaiting requested review from jfrankenau

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vincentbernat @babariviere @rileyinman @c0bw3b