New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added micronucleus #76621
Added micronucleus #76621
Conversation
Up? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, and stepping up as a maintainer! Some comments.
mkdir -p $out/bin | ||
mkdir -p $out/lib/udev | ||
cp micronucleus $out/bin | ||
cp 49-micronucleus.rules $out/lib/udev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Future work, not needed for this PR:
You might want to PR a makefile change upstream, which updates their install taget to use DESTDIR
and installs the udev rule too.
We'd then only need to set makeFlags = [ "DESTDIR=$(out)" ];
, and could drop the custom installPhase
alltogether for the next release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, format your commit messages according to CONTRIBUTING.md
.
28f9643
to
bce79e6
Compare
Done |
No, the second commit should be `micronucleus: init at 2.04`.
|
Done.
On January 1, 2020 11:53:53 PM GMT+01:00, Florian Klink ***@***.***> wrote:
No, the second commit should be `micronucleus: init at 2.04`.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#76621 (comment)
—
cab
|
@GrahamcOfBorg build micronucleus |
Build fails on darwin, because upstreams makefile hardcodes You could try setting |
can i just use clang then? |
@GrahamcOfBorg build micronucleus |
1 similar comment
@GrahamcOfBorg build micronucleus
|
Motivation for this change
Micronucleus is a nice bootloader for ATTiny boards, and is used by Digispark. This is a command line tool to flash stuff into it.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)