Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pacman: 5.1.3 -> 5.2.1 #74892

Merged
merged 1 commit into from Dec 3, 2019
Merged

pacman: 5.1.3 -> 5.2.1 #74892

merged 1 commit into from Dec 3, 2019

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

Updates pacman to the latest version. configure.ac has a problem in the git tarball, causing the following error:

./configure: line 14968: syntax error near unexpected token `$file_version,'
./configure: line 14968: `      AX_COMPARE_VERSION($file_version, ge, 5.38, with_file_seccomp=yes)'

I switched to using the release tarball used by the official Arch package, which seems to have been fixed. This also eliminates the need for autoreconfHook.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @mt-caret

@ofborg ofborg bot requested a review from mt-caret December 3, 2019 04:00
jonringer
jonringer approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

[3 built, 2 copied (0.4 MiB), 0.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/74892
1 package were built:
pacman

@jonringer jonringer merged commit 20605f8 into NixOS:master Dec 3, 2019
@lopsided98 lopsided98 deleted the pacman-update branch December 3, 2019 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@mt-caret mt-caret Awaiting requested review from mt-caret

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lopsided98 @jonringer