Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow document access iframe attribute. #20565

Merged
merged 1 commit into from Dec 4, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Dec 2, 2019

Remove document-access feature policy.

Change feature policy to an iframe attribute since feature policies
inherit and it really doesn't give us the characteristics we wish for.

Explainer: https://github.com/dtapuska/documentaccess

BUG=961448

Change-Id: Iee24cbd3dff53bd94153104bce250e3f9a947639
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926788
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721227}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

Remove document-access feature policy.

Change feature policy to an iframe attribute since feature policies
inherit and it really doesn't give us the characteristics we wish for.

Explainer: https://github.com/dtapuska/documentaccess

BUG=961448

Change-Id: Iee24cbd3dff53bd94153104bce250e3f9a947639
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926788
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721227}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants