Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix converting vam.pluginDictionaries to VimL #74846

Merged
merged 1 commit into from Mar 19, 2020
Merged

Fix converting vam.pluginDictionaries to VimL #74846

merged 1 commit into from Mar 19, 2020

Conversation

rummik
Copy link
Contributor

@rummik rummik commented Dec 2, 2019 •
edited

Motivation for this change

Fix a regression that broke outputting attributes on VAM's plugin dictionaries. This also makes naming a little more clear, and escapes the strings it outputs, fixing a bug in the conversion

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @jonringer

@jonringer
Copy link
Contributor

Fix a regression that broke outputting attributes on VAM's plugin dictionaries.

is this still an issue? there was another for plugin loading that was merged recently

cc @timokau @evanjs

@timokau
Copy link
Member

timokau commented Mar 13, 2020

I don't know, I've never really used vam and I'm not familiar with that part of the infrastructure. If you're referring to #78385, that's almost certainly irrelevant to this issue.

@rummik is this still relevant?

@rummik
Copy link
Contributor Author

rummik commented Mar 19, 2020

@timokau Sorry for the delay in reply. The code that handles serialization to VimL wasn't touched in #78385, so I still have been using this in order to have exec and filename_regex passed to VAM

@rummik
Copy link
Contributor Author

rummik commented Mar 19, 2020

As an example, this is one of the places where I've needed this conversion: config/neovim.nix#L432-L438

timokau
timokau requested changes Mar 19, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case let's go ahead with this. As I said, I don't know much about vam but @rummik seems to know what they're doing and the diff looks good to me.

Can you prefix your commit message with vim-utils:?

@rummik rummik requested a review from timokau March 19, 2020 21:24
@rummik
Copy link
Contributor Author

rummik commented Mar 19, 2020

@timokau Done! 😁

@timokau
Copy link
Member

timokau commented Mar 19, 2020

Thanks for taking the care for this! Sorry you had to bring so much patience to the table for your first contribution. Its just an area of the code that not many people are comfortable with.

Welcome to the team :)

@timokau timokau merged commit 71331ee into NixOS:master Mar 19, 2020
@jonringer
Copy link
Contributor

@timokau seconded!

@rummik thank you for putting up with our antics. Hard to give good feedback when (at least I) we lack in context about a particular framework. Hope to see more contributions :)

@rummik
Copy link
Contributor Author

rummik commented Mar 20, 2020

Understandable! xD Reviewers seem spread pretty thin anyway, so I wasn't really worrying about it 😅

@rummik rummik deleted the vam-regression branch March 20, 2020 15:27
@rummik
Copy link
Contributor Author

rummik commented Mar 20, 2020

And thanks as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau timokau approved these changes

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: vim 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rummik @jonringer @timokau