Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.responses: 0.10.6 -> 0.10.7 #74799

Closed
wants to merge 1 commit into from
Closed

python3Packages.responses: 0.10.6 -> 0.10.7 #74799

wants to merge 1 commit into from

Conversation

mtrsk
Copy link
Member

@mtrsk mtrsk commented Dec 1, 2019

Motivation for this change

Removed doCheck = false and added the necessary deps so the unit tests are run. Added some meta info in the derivation and bumped the version from 0.10.6 to 0.10.7.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer jonringer mentioned this pull request Dec 2, 2019
Merged
10 tasks
@FRidh
Copy link
Member

FRidh commented Feb 10, 2020

0.10.9 is in master

@FRidh FRidh closed this Feb 10, 2020
@mtrsk mtrsk deleted the update-python-package branch February 10, 2020 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mtrsk @FRidh @jonringer