Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libtermkey: compile with unibilium #74801

Merged
merged 1 commit into from Dec 5, 2019
Merged

libtermkey: compile with unibilium #74801

merged 1 commit into from Dec 5, 2019

Conversation

teto
Copy link
Member

@teto teto commented Dec 1, 2019 •
edited

While working on neovim, I noticed the functionaltests were failing neovim/neovim#11429. There are bugs in libtermkey that can't load the terminfo driver for some values of TERM. As per libtermkey's author:

To be honest, unibilium is basically a requirement now. I
might just change the code to throw away the other bits and make it a
dependency.

building with unibilium solved all my issues.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

c0bw3b
c0bw3b reviewed Dec 4, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we have a PR open for this package, could you also set meta.homepage ?

pkgs/development/libraries/libtermkey/default.nix Outdated Show resolved Hide resolved
@teto
Copy link
Member Author

teto commented Dec 5, 2019

@GrahamcOfBorg build libtermkey

@teto
libtermkey: compile with unibilium
2ebb5ef 
As the alternative isn't well tested and will be ruled out very soon.
@teto teto merged commit 9c6ceb5 into NixOS:master Dec 5, 2019
@teto teto deleted the fix_libtermkey branch December 5, 2019 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@teto @c0bw3b