Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce font size of text-transform tests so they fit within the reftest screenshot size. #20566

Merged
merged 1 commit into from Dec 3, 2019

Conversation

dbaron
Copy link
Member

@dbaron dbaron commented Dec 2, 2019

Per CSSWG resolution at
https://lists.w3.org/Archives/Public/www-style/2012Sep/0562.html
reftests should fit within a 600x600 screenshot.

This reduces most tests from 250% font-size and 2.5em line-height to
125% font-size and 1.5em line-height. The small number that don't fit
at that size are further reduced to 100% font-size.

(Firefox has a failure text-transform-upperlower-016.html that is
outside of the screenshot area; this moves it in!)

…st screenshot size.

Per CSSWG resolution at
https://lists.w3.org/Archives/Public/www-style/2012Sep/0562.html
reftests should fit within a 600x600 screenshot.

This reduces most tests from 250% font-size and 2.5em line-height to
125% font-size and 1.5em line-height.  The small number that don't fit
at that size are further reduced to 100% font-size.

(Firefox has a failure text-transform-upperlower-016.html that is
outside of the screenshot area; this moves it in!)
@gsnedders
Copy link
Member

(FWIW, the WPT definition changed back a year or two ago to the legacy CSS WG size of 800x600 given the 600x600 was motivated by B2G and there were so many tests that painted outwith the 600x600 viewport.)

@dbaron
Copy link
Member Author

dbaron commented Dec 2, 2019

Ah, ok. I guess that is documented.

In any case, I think these changes are still reasonable and in many cases still needed -- some of these tests weren't anywhere close to fitting. (Some of the ones I made 100% could probably be 125% given that, though, but it's probably conservative to leave them as 100% since I was basing it purely on "didn't fit in a single browser".)

@gsnedders gsnedders merged commit 9715e6e into web-platform-tests:master Dec 3, 2019
@gsnedders
Copy link
Member

(stability job failure is pre-existing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants