Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.fido2: 0.7.3 -> 0.8.1 #74816

Merged
merged 1 commit into from Dec 2, 2019
Merged

python3Packages.fido2: 0.7.3 -> 0.8.1 #74816

merged 1 commit into from Dec 2, 2019

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Dec 2, 2019 •
edited

Motivation for this change

Version update, fixes #74805

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@prusnak prusnak mentioned this pull request Dec 2, 2019
Closed
@veprbl
Copy link
Member

veprbl commented Dec 2, 2019

@GrahamcOfBorg build python2Packages.fido2
@GrahamcOfBorg build python3Packages.fido2

@veprbl
Copy link
Member

veprbl commented Dec 2, 2019

@GrahamcOfBorg build yubioath-desktop python2Packages.solo-python python3Packages.solo-python yubikey-manager-qt yubikey-manager gen-oath-safe

@veprbl
Copy link
Member

veprbl commented Dec 2, 2019

Hate to pick on bugfix, but this appears to be breaking python3Packages.solo-python. I made an upstream issue solokeys/solo1-cli#49
Also cc @wucke13

@prusnak
Copy link
Member Author

prusnak commented Dec 2, 2019 •
edited

As solo-python is unusable anyway (because its dependency does not build), I'd say let's merge this and fix solo-python later (once upstream fixes the issue).

@veprbl
Copy link
Member

veprbl commented Dec 2, 2019

@prusnak Well, there is an alternative of reverting a8d207c that would fix all of the packages. Unfortunately, there doesn't seem to be a way to prevent automated fido2 bump from landing on master again, so I'm leaning towards merging this as well.

@veprbl
Copy link
Member

veprbl commented Dec 2, 2019

Actually, there seems to be a fix: solokeys/solo1-cli#47

@veprbl veprbl merged commit e678aad into NixOS:master Dec 2, 2019
@veprbl
Copy link
Member

veprbl commented Dec 2, 2019

@prusnak Thank you!

@prusnak prusnak deleted the python-fido2 branch December 2, 2019 16:07
@veprbl
Copy link
Member

veprbl commented Dec 2, 2019

Opened issue to track solo-python: #74835

@jtojnar jtojnar mentioned this pull request Dec 2, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

python3Packages.fido2 doesn't build
2 participants
@prusnak @veprbl