Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gegl_0_4: disabling jasper, fixing build #74790

Merged
merged 1 commit into from Dec 2, 2019
Merged

gegl_0_4: disabling jasper, fixing build #74790

merged 1 commit into from Dec 2, 2019

Conversation

d-goldin
Copy link
Contributor

@d-goldin d-goldin commented Dec 1, 2019

Motivation for this change

Jasper has been recently marked as insecure and removed from a bunch
of places due to some known vulnerabilities and upstream not moving
forward. This was done in #73586

This prevents gegl_0_4 from building, as jasper is a runtime dependency
per default. There is an upstream issue for that, but it does not seem
to have made progress yet: https://gitlab.gnome.org/GNOME/gegl/issues/35

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @c0bw3b @jtojnar

@d-goldin
gegl_0_4: disabling jasper, fixing build
c9841ed 
Jasper has been recently marked as insecure and removed from a bunch
of places due to some known vulnerabilities and upstream not moving
forward. This was done in NixOS#73586

This prevents gegl_0_4 from building, as jasper is a runtime dependency
per default. There is an upstream issue for that, but it does not seem
to have made progress yet: https://gitlab.gnome.org/GNOME/gegl/issues/35
@ofborg ofborg bot requested a review from jtojnar December 1, 2019 16:26
@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 1, 2019

👍
jasper previously managed to be in the build scope through gdk-pixbuf -> librsvg apparently

@c0bw3b c0bw3b added this to WIP in Staging via automation Dec 1, 2019
@c0bw3b c0bw3b moved this from WIP to Ready in Staging Dec 1, 2019
@jtojnar
Copy link
Contributor

jtojnar commented Dec 2, 2019

This should go to staging-next now. #74795

@jtojnar jtojnar changed the base branch from staging to staging-next December 2, 2019 11:20
@ofborg ofborg bot requested a review from jtojnar December 2, 2019 11:35
@jtojnar jtojnar merged commit 65a0078 into NixOS:staging-next Dec 2, 2019
Staging automation moved this from Ready to Done Dec 2, 2019
@d-goldin
Copy link
Contributor Author

d-goldin commented Dec 2, 2019

@jtojnar: Oh, sorry, I thought this was for the author of the staging-next PR to cherry-pick. Thanks for handling it.

@d-goldin d-goldin deleted the gegl_0_4_jasper branch December 2, 2019 12:23
@jtojnar
Copy link
Contributor

jtojnar commented Dec 2, 2019

If it fixes a direct breakage in staging-next, it is better to fix it directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@d-goldin @c0bw3b @jtojnar