crystal.buildCrystalPackage: add checkPhase #74919
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`crystal spec` is the way to run tests in Crystal. `doCheck` is being enabled by default.
|
@GrahamcOfBorg build crystal2nix mint |
|
#74921 probably should be merged first - it fixes the build failure with |
|
Superseded by #83054. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
crystal specis the way to run tests in Crystal.doCheckis being enabled by default.Currently, these packages use
buildCrystalPackageand need to be built:crystal2nix-unstable-2018-07-31- doesn't build on Darwinmint-0.5.0- doesn't build, resolved in mint: 0.5.0 -> 0.7.1 #74921Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @manveru @david50407 @peterhoeg
This change is