Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mint: 0.5.0 -> 0.7.1 #74921

Closed
wants to merge 4 commits into from
Closed

mint: 0.5.0 -> 0.7.1 #74921

wants to merge 4 commits into from

Conversation

Br1ght0ne
Copy link
Member

@Br1ght0ne Br1ght0ne commented Dec 3, 2019 •
edited

Motivation for this change

https://github.com/mint-lang/mint/releases/tag/0.7.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @manveru

This change is Reviewable

@Br1ght0ne Br1ght0ne mentioned this pull request Dec 3, 2019
Closed
12 tasks
@ofborg ofborg bot requested a review from manveru December 3, 2019 16:24
@Br1ght0ne Br1ght0ne changed the title mint: 0.5.0 -> 0.6.0 mint: 0.5.0 -> 0.7.0 Dec 9, 2019
@Br1ght0ne
Copy link
Member Author

@GrahamcOfBorg build mint

@manveru
Copy link
Contributor

manveru commented Dec 12, 2019

Seems to have issues on darwin, but I have no way to debug those.

@manveru
Copy link
Contributor

manveru commented Dec 12, 2019

Also this will fail once #75545 is merged. Please specify the crystal version as crystal_0_31 to prevent that.

@Br1ght0ne
Copy link
Member Author

@manveru No need - seems that Mint maintainers are quickly updating the code to keep up with the latest stable release of Crystal.

As soon as Crystal 0.32 is merged, I can rebase this PR to check if it builds. But for now:
@GrahamcOfBorg build mint

@ofborg ofborg bot requested a review from manveru December 13, 2019 13:10
@manveru
Copy link
Contributor

manveru commented Dec 13, 2019 •
edited

I asked the maintainer for a fix, so there's https://github.com/mint-lang/mint/releases/tag/0.7.1 now.
Ah, github didn't update the page, seems like you got it already :)

@Br1ght0ne Br1ght0ne changed the title mint: 0.5.0 -> 0.7.0 mint: 0.5.0 -> 0.7.1 Dec 13, 2019
@Br1ght0ne
Copy link
Member Author

Handled by #80391.

@Br1ght0ne Br1ght0ne closed this Feb 26, 2020
@Br1ght0ne Br1ght0ne deleted the mint-0.6.0 branch February 26, 2020 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manveru manveru Awaiting requested review from manveru

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Br1ght0ne @manveru