Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minijail: install .pc files and scoped_minijail.h #74860

Merged
merged 1 commit into from Dec 17, 2019
Merged

minijail: install .pc files and scoped_minijail.h #74860

merged 1 commit into from Dec 17, 2019

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented Dec 2, 2019

This matches the behaviour of the Chromium OS ebuild for this package:
https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/cd6d6815b1604105cb6b8c40b2e0c3f15f401e3b/chromeos-base/minijail/minijail-10-r38.ebuild#47

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@7c6f434c
Copy link
Member

And just in case, as the bot did not succeed to request review: @pcarrier any comments?

@matthewbauer matthewbauer merged commit b39bc29 into NixOS:master Dec 17, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Dec 17, 2019
@matthewbauer @dtzWill
Merge pull request NixOS#74860 from alyssais/minijail
cbbe4a7 
minijail: install .pc files and scoped_minijail.h
(cherry picked from commit b39bc29)
@pcarrier
Copy link
Contributor

@7c6f434c none, LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c 7c6f434c approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alyssais @7c6f434c @pcarrier @matthewbauer