Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fetchFromGitLab: improve readability #74861

Merged
merged 1 commit into from Dec 9, 2019
Merged

fetchFromGitLab: improve readability #74861

merged 1 commit into from Dec 9, 2019

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented Dec 2, 2019

Tested with a couple of packages that this results in the same hash.

davidak
davidak approved these changes Dec 4, 2019
View reviewed changes
Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

not tested

@alyssais
Copy link
Member Author

alyssais commented Dec 4, 2019

In that case I’ll merge in a few days or so unless anybody raises objections before then.

@alyssais alyssais merged commit ee49b45 into NixOS:master Dec 9, 2019
@alyssais alyssais deleted the fetchgitlab branch December 9, 2019 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidak davidak davidak approved these changes

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
6.topic: fetch 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alyssais @davidak @c0bw3b