[LayoutNG] Set column fragments to the actual column size. #20585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 3, 2019
Just letting the fragmentation machinery do what it would do if it gets to treat column boxes as regular column content was no conscious choice, and it turns out that setting the column fragments to the actual column size is better, or we get some trouble with overflow, both when it comes to painting column rules, and the fact that we get spurious empty column fragments after unbreakable content (new unit test NGColumnLayoutAlgorithmTest.TallReplacedContent). Remove fast/multicol/rule-in-nested-with-too-tall-line.html and replace it with a valid test (that still fails both in legacy and NG; in NG because we fail to paint text on a general basis). Bug: 829028 Change-Id: I3656c299c7a87bea29e1790477cf524b9522fa97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948923 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#721376}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1948923
branch
from
b66aad7
to
40da4f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just letting the fragmentation machinery do what it would do if it gets
to treat column boxes as regular column content was no conscious choice,
and it turns out that setting the column fragments to the actual column
size is better, or we get some trouble with overflow, both when it comes
to painting column rules, and the fact that we get spurious empty column
fragments after unbreakable content (new unit test
NGColumnLayoutAlgorithmTest.TallReplacedContent).
Remove fast/multicol/rule-in-nested-with-too-tall-line.html and replace
it with a valid test (that still fails both in legacy and NG; in NG
because we fail to paint text on a general basis).
Bug: 829028
Change-Id: I3656c299c7a87bea29e1790477cf524b9522fa97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948923
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721376}