Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netease-cloud-music: init at 1.2.0 #74775

Merged
merged 1 commit into from Dec 8, 2019
Merged

netease-cloud-music: init at 1.2.0 #74775

merged 1 commit into from Dec 8, 2019

Conversation

Ninlives
Copy link
Contributor

@Ninlives Ninlives commented Dec 1, 2019

Motivation for this change

Add package for the client of Netease Cloud Music service

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Ninlives Ninlives force-pushed the netease-player branch 2 times, most recently from ceed293 to e5aed07 Compare December 2, 2019 14:46
@Ninlives
Copy link
Contributor Author

Ninlives commented Dec 3, 2019

What additional work should I make for this PR to be merged?

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/88

Lassulus
Lassulus requested changes Dec 7, 2019
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there should also be an entry in pkgs/top-level/all-packages.nix

@Ninlives
cherry pick
6989213 
modify all-packages.nix
@Ninlives
Copy link
Contributor Author

Ninlives commented Dec 8, 2019

@Lassulus Done. Sorry, I think I accidentally discarded some commits when trying to squash -_-||

Lassulus
Lassulus approved these changes Dec 8, 2019
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-review, seems to work, but I can't read anything

@Lassulus Lassulus merged commit c5ca589 into NixOS:master Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Lassulus approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ninlives @nixos-discourse @Lassulus