Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox-bin: 70.0.1 -> 71.0, firefox-esr: 68.2.0esr -> 68.3.0esr #74907

Closed
wants to merge 2 commits into from
Closed

firefox-bin: 70.0.1 -> 71.0, firefox-esr: 68.2.0esr -> 68.3.0esr #74907

wants to merge 2 commits into from

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Dec 3, 2019

Motivation for this change

Release notes are not updated yet.

https://www.mozilla.org/en-US/firefox/71.0/releasenotes/
https://www.mozilla.org/en-US/firefox/68.3.0/releasenotes/

See also #74905.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Tested only firefox-bin. firefox-esr is being built.

Notify maintainers

cc @edolstra @andir

@taku0 taku0 mentioned this pull request Dec 3, 2019
Merged
10 tasks
@taku0
Copy link
Contributor Author

taku0 commented Dec 3, 2019

#74905 will incorporate firefox-bin and firefox-esr. Closing this as a duplicate.

@taku0 taku0 closed this Dec 3, 2019
@ofborg ofborg bot requested review from edolstra and andir December 3, 2019 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

@andir andir Awaiting requested review from andir

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@taku0