Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.bigstring: init at 0.2 #74819

Merged
merged 1 commit into from Apr 27, 2020
Merged

ocamlPackages.bigstring: init at 0.2 #74819

merged 1 commit into from Apr 27, 2020

Conversation

alexfmpe
Copy link
Member

@alexfmpe alexfmpe commented Dec 2, 2019 •
edited

Motivation for this change

Dependency of tezos

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@bennofs bennofs closed this Apr 27, 2020
@bennofs
Copy link
Contributor

bennofs commented Apr 27, 2020

Sorry, I misread and confused bitstring vs bigstring

@bennofs bennofs reopened this Apr 27, 2020
@bennofs bennofs force-pushed the ocamlPackages-bigstring-init branch from 16a9352 to 2335d2c Compare April 27, 2020 09:37
@bennofs bennofs force-pushed the ocamlPackages-bigstring-init branch from 2335d2c to 05d97f7 Compare April 27, 2020 09:37
@bennofs
Copy link
Contributor

bennofs commented Apr 27, 2020

I rebased this onto master, will merge after ofborg finishes.

@bennofs bennofs merged commit ce6dbcc into NixOS:master Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexfmpe @bennofs