Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.genspio: init at 0.0.2 with dependencies #74820

Merged
merged 1 commit into from Aug 21, 2020

Conversation

alexfmpe
Copy link
Member

@alexfmpe alexfmpe commented Dec 2, 2019

Motivation for this change

Dependency of tezos

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@stale
Copy link

stale bot commented Jun 26, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 26, 2020
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 15, 2020
pkgs/development/ocaml-modules/sosa/default.nix Outdated Show resolved Hide resolved
pkgs/development/ocaml-modules/genspio/default.nix Outdated Show resolved Hide resolved
Copy link
Contributor

@vbgl vbgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also please rebase and squash all these commits? Thanks.

pkgs/development/ocaml-modules/sosa/default.nix Outdated Show resolved Hide resolved
@vbgl
Copy link
Contributor

vbgl commented Aug 20, 2020

@GrahamcOfBorg build ocamlPackages.genspio

Copy link
Contributor

@vbgl vbgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set the minimumOCamlVersion of genspio to something larger than or equal to "4.03". Thanks.

Indeed, build fails with OCaml 4.02:

File "src/lib/language.ml", line 51, characters 14-15:
Error: Syntax error

@vbgl vbgl merged commit a3aae22 into NixOS:master Aug 21, 2020
@vbgl
Copy link
Contributor

vbgl commented Aug 21, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants